[PIPE2D-609] Polish generateCommands.py Created: 23/Jun/20  Updated: 05/Jan/21  Resolved: 25/Jun/20

Status: Done
Project: DRP 2-D Pipeline
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Story Priority: Normal
Reporter: price Assignee: sogo.mineo
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Sprint: 2DDRP-2021 A
Reviewers: price

 Description   

In the process of using generateCommands.py, I've noticed some behaviours which deserve addressing:

  • I can't specify multiple types via --calibTypes.
  • If the particular calib has already been ingested, the generated script fails (RuntimeError: File ... already exists; consider --config clobber=True) despite --force, and I'm unaware of any means of setting clobber=True in the ingestion.
  • If I have a local subdirectory CALIB, running generateCommands.py /path/to/DATA/ --calib CALIB ... sets the calibration directory to /path/to/DATA/CALIB rather than CALIB.

 Comments   
Comment by sogo.mineo [ 23/Jun/20 ]
  • To pass two or more arguments to --calibTypes, write --calibTypes arg1 arg2 arg3 ....
  • I don't think it is good to give --force two different functions: one for script generation and another for script execution. I would suggest adding --clobber-calib.
  • What --calib is relative to is confusing indeed. I will change it.
Comment by sogo.mineo [ 24/Jun/20 ]
  • --calib is now relative to $PWD.
  • Added --overwriteCalib option. With this option, ingestPsfCalibs.py will overwrite old calibs instead of raising an exception.
Comment by sogo.mineo [ 25/Jun/20 ]

Thanks for review. I added a check that calib exists, renamed outputCalibType to outputSubdir, and merged this branch to master.

Generated at Sat Feb 10 15:55:22 JST 2024 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.