[PIPE2D-600] Migrate the weekly test to use YAML config files Created: 10/Jun/20 Updated: 05/Jan/21 Resolved: 17/Jun/20 |
|
| Status: | Done |
| Project: | DRP 2-D Pipeline |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Task | Priority: | Normal |
| Reporter: | sogo.mineo | Assignee: | sogo.mineo |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Story Points: | 2 | ||||||||
| Sprint: | 2DDRP-2021 A | ||||||||
| Reviewers: | price | ||||||||
| Description |
|
Migrate pfs_pipe2d/weekly/process_weekly.sh to use YAML config files just like the integration test ( |
| Comments |
| Comment by sogo.mineo [ 11/Jun/20 ] |
|
I need files in RAWDATA=/projects/HSC/PFS/weekly (in jenkins_weekly.sh) so as to know how process_weekly.sh works. |
| Comment by sogo.mineo [ 11/Jun/20 ] |
|
I thought I could create raw images with weekly/create_weekly.sh but it seems broken now: price ? |
| Comment by price [ 12/Jun/20 ] |
|
You need the simulator (drp_instdata, drp_instmodel) to create the weekly, and it can take a while to run. I've copied the data to IPMU, at gfarm:/gpfs02/work/price/weekly. It's also available here. |
| Comment by sogo.mineo [ 12/Jun/20 ] |
|
I downloaded the files. Thank you. |
| Comment by sogo.mineo [ 15/Jun/20 ] |
|
weekly/process_weekly.sh now calls generateCommands.py with examples/weekly.yaml as the argument. I had to modify python/pfs/pipe2d/weekly/utils.py in order to delete weekly/b[rm]n_visits.dat. |
| Comment by sogo.mineo [ 16/Jun/20 ] |
|
Thanks for review. I newly introduced getVisitsByBlockName() in python/pfs/pipe2d/weekly/utils.py. Is this OK? If it is OK, I will merge this branch to master. |
| Comment by sogo.mineo [ 17/Jun/20 ] |
|
Merged to master. |