[PIPE2D-597] DRP and ICS have conflicting requirements for {{attrs}} package version Created: 03/Jun/20 Updated: 12/Sep/22 |
|
| Status: | Open |
| Project: | DRP 2-D Pipeline |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Task | Priority: | Normal |
| Reporter: | cloomis | Assignee: | price |
| Resolution: | Unresolved | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Story Points: | 4 | ||||||||
| Description |
|
The DRP stack has pinned pytest 3.6.2 (from 2018-07), which requires attrs < 19.2.0. ICS (and thus ics_drpActor) requires a modern twisted library, which requires attrs >= 19.2.0 At the next level of detail, 19.2.0 removed a deprecated alias attr.ib(convert=) for attr.ib(converter=), which pytest 3.6.2 uses in one place. pytest 3.6.3 fixes that. And 19.2.0 introduced a new attrs argument which twisted now uses: attr.s(eq=). attrib and attrs look like a pain to monkey patch. For now I have renamed the one call in the installed pytest at Subaru. |
| Comments |
| Comment by cloomis [ 06/Jun/20 ] |
|
To be clear I think we can skate on this one: the hack is gross but really limited both in size and location. It will never become a support issue outside of me and Arnaud. It would be nice to know whether there are any plans to update the pytest package. |
| Comment by price [ 06/Jun/20 ] |
|
I don't intend to update the pytest package explicitly, but it will be updated as a side effect of upgrading the LSST stack in the future. |
| Comment by hassan [ 06/Jun/20 ] |
|
Moved this to top of backlog for moment. |
| Comment by cloomis [ 26/Jun/20 ] |
|
To be prescriptive: (lsst-scipipe-1172c30) -bash-4.2$ diff ./3.6.2.lsst2+2/lib/python/pytest-3.6.2-py3.7.egg/_pytest/mark/structures.py~ ./3.6.2.lsst2+2/lib/python/pytest-3.6.2-py3.7.egg/_pytest/mark/structures.py 284c284 < _marks = attr.ib(convert=list) --- > _marks = attr.ib(converter=list) |
| Comment by cloomis [ 11/Nov/20 ] |
|
Forgot to explicitly add that the attrs conda package does need to be updated. 19.3.0 is what we have tested with. |
| Comment by price [ 12/Sep/22 ] |
|
cloomis: Is this still a problem? |