[PIPE2D-570] Refactor findAndTraceApertures Created: 30/Apr/20  Updated: 05/Jan/21  Resolved: 30/May/20

Status: Done
Project: DRP 2-D Pipeline
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Story Priority: Normal
Reporter: price Assignee: price
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Sprint: 2DDRP-2021 A
Reviewers: hassan

 Description   

findAndTraceApertures is a C++ function with lots of branches, which makes it difficult to follow, maintain and debug. It should be replaced using a simpler algorithm, and a more modular implementation that is accessible from python.



 Comments   
Comment by price [ 13/May/20 ]

At the moment we're measuring the fiber profile from the data, but one could imagine generating it from the known NevenPsf and DetectorMap.

Comment by rhl [ 13/May/20 ]

That would be great, avoiding the need for even/odd flats, but I'm not convinced that it'd work well enough. The comparison would be very interesting, though.

As Paul knows, we should integrate the location of the traces with the detector map, even if we don't measure the profiles that way

Comment by price [ 13/May/20 ]

I would love to replace FiberTrace (that essentially encodes position and profile) with a new FiberProfile object (that encodes only the profile, and use the DetectorMap for the position). However, PfsFiberTrace is part of the datamodel, so I think I need a firm proposal first, and perhaps an improved DetectorMap.

Comment by cloomis [ 14/May/20 ]

+many. Every time we have discussed this, we have wanted to separate the trace positions from the fiber shape.

Comment by rhl [ 14/May/20 ]

I've never pushed back on eventually replacing Andreas' code; it's a question of priorities. We'll know more once we have lots of SCR data.
Re Paul's point: I don't think we need worry about the data model (we can update it), although we do need to be careful not to break people's work flows/notebooks. I can imagine ways to providing backwards compatibility in the butler.

Comment by price [ 28/May/20 ]

This is a large addition. It doesn't change the state of the pipeline, but adds potential to change it in the future. It will be used for PIPE2D-472.

Comment by price [ 30/May/20 ]

Merged to master.

Generated at Sat Feb 10 15:54:58 JST 2024 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.