[PIPE2D-557] Convert linelist status to bitflag format Created: 16/Apr/20  Updated: 20/Apr/21  Resolved: 20/Apr/21

Status: Done
Project: DRP 2-D Pipeline
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Story Priority: Normal
Reporter: hassan Assignee: price
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Blocks
blocks PIPE2D-558 Update linelist with broadened lines ... Done
Relates
relates to PIPE2D-673 Make it possible to return all lines ... Done
Story Points: 2
Sprint: 2DDRP-2021 A 2, 2DDRP-2021 A3, 2DDRP-2021 A 4
Reviewers: hassan

 Description   

The arc lamp linelist used for calibrating the SpS maintained here:

https://github.com/Subaru-PFS/obs_pfs/blob/master/pfs/lineLists/ArCdHgKrNeXe.txt

and for each line a status is provided:

# Status:
#  0   Isolated, good
#  1   Not visible
#  2   Blend; don't use
#  3   Unreliable when processing sim data (PIPE2D-314)
#  4   Commonly has large residuals (PIPE2D-436)
#  5   Commonly has large residuals (NeI, sims blue arm; PIPE2D-391)

Following today's ICS/SpS telecon, this status information is better encoded as sequence of bit flags. Define the bit flags and update the linelist file and software accordingly.

Note that this could be a breaking change. This should be scheduled carefully so as to avoid problems when running the DRP particularly with ongoing activities at Subaru and LAM.

 Comments   
Comment by rhl [ 04/Dec/20 ]

At the same time, we should add a field in ReferenceLine containing this bit mask.
We then either need to add a mask (e.g. flagsToIgnore) to readLineListFile, or add this functionality to the code that uses the lines.

Comment by price [ 14/Apr/21 ]

tickets/PIPE2D-557 (obs_pfs and drp_stella) contains a big refactoring of ReferenceLine in support of this ticket plus others (including PIPE2D-755 and PIPE2D-801).

Comment by hassan [ 17/Apr/21 ]

Changes in general look fine. References to IdentifyLineTask in ReduceArcTask still present so should be removed (if that is still the intent).

Comment by price [ 20/Apr/21 ]

Merged.

Generated at Sat Feb 10 15:54:50 JST 2024 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.