[PIPE2D-521] Create global PSF solutions for the July 2019, using 2020 improvments Created: 12/Mar/20 Updated: 29/Apr/20 Resolved: 23/Apr/20 |
|
| Status: | Done |
| Project: | DRP 2-D Pipeline |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Task | Priority: | Normal |
| Reporter: | ncaplar | Assignee: | ncaplar |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Attachments: |
|
||||||||||||||||||||||||||||||||
| Issue Links: |
|
||||||||||||||||||||||||||||||||
| Story Points: | 20 | ||||||||||||||||||||||||||||||||
| Reviewers: | price | ||||||||||||||||||||||||||||||||
| Description |
|
This is to create the 2d PSF solution for the July data, using the improvements from 2020:
I have created 3 ``subtickets'', in an effort to granulate the problem and make it easier to track different steps towards the final goal.
|
| Comments |
| Comment by ncaplar [ 21/Apr/20 ] |
|
I hope that I am close to creating the first version of the solution. I am adding Figure ``Overview.png'' which shows that is the minimal value of predicted LSF across the detector (as a function of fiber and y-value on the detector). As you can see there is not a single position where the LSF is negative. At the moment I am studying the strange cluster of the high value at y=650. When I solve this, I think this can be the first version of new solutions. |
| Comment by ncaplar [ 21/Apr/20 ] |
|
I am almost certain that the problem is that I have been extra stupid when doing extrapolation...
|
| Comment by ncaplar [ 22/Apr/20 ] |
|
I have added ``Overview_interpolation.png'' which shows that is the minimal value of predicted LSF across the detector (as a function of fiber and y-value on the detector). This new figure is created with the new interpolation schema that I am proposing. Beforehand the algorithm was searching for two nearest points to either interpolate or extrapolate the solution. The new schema searching for two spots which straddle the position that you are asking for, i.e., it always does the interpolation. If you are asking for a position that is outside the last available spot (at the edges of the wavelength coverage) the algorithm at the moment returns the last available spot, without any extrapolation. Therefore the solutions at the edges will be deficient in this type of algorithm. Covere_space.png shows the part of the space where we interpolate (dark blue) and where we do not interpolate (yellow). |
| Comment by ncaplar [ 23/Apr/20 ] |
|
Solutions are placed in `/tigress/ncaplar/ positions_of_simulation_00 array contains positions of each PSF model. The columns are: 1. fiberId, 2. approximate x coordinate, 3. approximate y coordinate, 4. wavelength. array_of_simulation_00 array contains arrays with 189x189 PSF models (9x times oversampled). At the moment there are *_Apr15_v1 and *_Apr_v2 versions. *_Apr15_v1 version is created with the lines as they appear on the detector, i.e., the with broad HgAr lines identified in *_Apr15_v2 version is created by artificially narrowing these lines, i.e, how I believe they should appear if they were not broadened due to atomic issues. This narrowing is done quite crudely at the moment, I just set the argument controlling the Lorentzian width component so that is roughly similar to the other nearby lines. This needs to be improved. These PSFs are valid for F/2.8 data taken in July 2019 (e.g., runs 21400, 21604 and 21808.) |
| Comment by ncaplar [ 23/Apr/20 ] |
|
The updated method is available at https://github.com/Subaru-PFS/dev_2ddrp/blob/master/2d_PSF_code/PIPE2D-521/Provide_PSF_2D.py |
| Comment by ncaplar [ 28/Apr/20 ] |
|
I have added *_Apr15_v3 solutions. The v3 version includes the artificial narrowing of the Hg lines, identified in |
| Comment by ncaplar [ 29/Apr/20 ] |
|
price identified that the new implementation did not handle the case when the requested spot is at the exact position of the input spot correctly. This has been rectified and pushed to https://github.com/Subaru-PFS/dev_2ddrp/blob/master/2d_PSF_code/PIPE2D-521/Provide_PSF_2D.py. |