pytest-drp_stella.xml.failed
|
Relates |
|||
| relates to |
|
installed failed | Won't Fix |
[PIPE2D-513] drp 2d install test failed Created: 12/Feb/20 Updated: 05/Jan/21 Resolved: 26/Feb/20 |
|
| Status: | Done |
| Project: | DRP 2-D Pipeline |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Bug | Priority: | Normal |
| Reporter: | fmadec | Assignee: | price |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Attachments: |
pytest-drp_stella.xml.failed
|
||||||||
| Issue Links: |
|
||||||||
| Sprint: | 2DDRP-2020 A, 2DDRP-2021 A | ||||||||
| Reviewers: | hassan | ||||||||
| Description |
|
install failed Failed test output: Global pytest output is in /home/pfs/drp/pfs/drp_stella/tests/.tests/pytest-drp_stella.xml.failed The following tests failed: /home/pfs/drp/pfs/drp_stella/tests/.tests/pytest-drp_stella.xml.failed 1 tests failed scons: *** [checkTestStatus] Error 1 scons: building terminated because of errors. |
| Comments |
| Comment by price [ 12/Feb/20 ] |
|
When reading the PSF files, it says:
> raise OSError('Header missing END card.')
E OSError: Header missing END card.
Please check that the files in drp_pfs_data (and in particular detectorMap-2019Apr-r1.fits are actual FITS files, and that git lfs has downloaded the proper content. |
| Comment by fmadec [ 12/Feb/20 ] |
|
right, it seems that drp_pfs_data is missing but I don't know why I made this install last November by using install_pfs.sh script and this time I wanted to update the drp_stella package. I tried build_pfs.sh -b master -l drp_stella but w/o sucess, so I tried build_pfs.sh -b master and gave me that error. is there new dependency (ie drp_pfs_data ) since last November? build_pfs.sh is the correct way to update one pfs package, right?
|
| Comment by price [ 12/Feb/20 ] |
|
The install script within pfs_pipe2d has been updated with the new dependency, and I'm guessing you have an old version. I suggest pulling pfs_pipe2d master from github. |
| Comment by fmadec [ 13/Feb/20 ] |
|
How should I proceed with my existing install ? because pfs_pipe2d is already installed , what is the proper way to update it ? a build_pfs.sh -l pfs_pipe2d will work ? or I need to git clone somewhere pfs_pipe2d , do a setup and then scons ? |
| Comment by price [ 13/Feb/20 ] |
|
Please clone pfs_pipe2d from github and use the bin scripts there to install. |
| Comment by fmadec [ 14/Feb/20 ] |
|
finally I completed the install today manually. There was indeed an issue with drp_pfs_data, the file were not fits file. it was a git-lfs issue, I had to do git-lfs clone build_pfs script does not handle git-lfs I have followed the doc https://github.com/Subaru-PFS/drp_doc/blob/master/pipelineUser/installation.rst git-lfs should be added as required (more clearly) in addition, integration_test failed on ubuntu, the git -c lfs.batch=true doesn't work.
|
| Comment by price [ 19/Feb/20 ] |
|
fmadec, could you please provide details on the integration test failure? A copy of the script's output would be helpful. |
| Comment by price [ 19/Feb/20 ] |
|
fmadec: I think the problem is that you didn't do git lfs install. I've expanded the section in the installation guide on installing git-lfs. Could you please have a look and verify that there is sufficient information? I've verified that the install_pfs.sh script works under both CentOS and Ubuntu through Docker, and the integration test is working fine for both after a few tweaks. hassan, could you please review those? |
| Comment by price [ 26/Feb/20 ] |
|
Merged to master. |
| Comment by hassan [ 05/Mar/20 ] |
|
The installation script worked fine for me on our local cluster. |