[PIPE2D-505] Provide object identifiers for the sky Created: 21/Dec/19 Updated: 05/Jan/21 Resolved: 24/Mar/20 |
|
| Status: | Done |
| Project: | DRP 2-D Pipeline |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Story | Priority: | Normal |
| Reporter: | hassan | Assignee: | price |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||
| Story Points: | 2 | ||||||||||||
| Sprint: | 2DDRP-2021 A | ||||||||||||
| Reviewers: | hassan | ||||||||||||
| Description |
|
Real object identifiers are required for sky data. Currently the operation pfsConfig.objId[pfsConfig.targetType == TargetType.SKY] returns an array of zeros. Please provide real identifiers for sky targets. |
| Comments |
| Comment by rhl [ 21/Dec/19 ] |
|
There should be no need to auto-generate sky object Ids, as they will be provided by e.g. HSC. When we write the pfsDesign files for the simulator (or probably really the pfsConfig files, as the final choice of sky object is made by the fibre allocation software) we need to provide objIds for the sky, and those will need to be made up — in just the same way as objIds are made up for any other target. |
| Comment by price [ 12/Mar/20 ] |
|
Now setting the objId for sky fibers in the simulator. I'm not going to bother re-running the simulator just for this (there doesn't seem an immediate need for this feature), but next time it we make a new data set, we should have non-zero objId for sky fibers. |
| Comment by rhl [ 17/Mar/20 ] |
|
When will you rerun the simulator with these set correctly? I found that they weren't while trying to validate the processing, this isn't just random tidiness |
| Comment by rhl [ 17/Mar/20 ] |
|
I see that you approved the pull request. How did you test it? |
| Comment by price [ 17/Mar/20 ] |
|
|
| Comment by price [ 17/Mar/20 ] |
>>> from pfs.datamodel import PfsDesign, TargetType
>>> dd = PfsDesign.read(1)
>>> objId = dd.objId[dd.targetType == TargetType.SKY]
>>> objId.min(), objId.max()
(61, 180)
|
| Comment by hassan [ 17/Mar/20 ] |
|
I was about to post a similar python script, using the LAM configuration. The objIds in my output were: (2,3). |
| Comment by price [ 24/Mar/20 ] |
|
Merged to master. |