[PIPE2D-502] Correct detectormaps for spatial effects as well as wavelength effects Created: 21/Dec/19 Updated: 05/Jan/21 Resolved: 08/Apr/20 |
|
| Status: | Done |
| Project: | DRP 2-D Pipeline |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Story | Priority: | Normal |
| Reporter: | hassan | Assignee: | price |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Sprint: | 2DDRP-2021 A | ||||||||
| Reviewers: | hassan | ||||||||
| Description |
|
It looks as if we're not updating the DetectorMaps' fibre trace *columns* in calibrateWavelength. An old RHL problem, but it may be why the vector plots are weird (or why you built them off arcs!) CalibrateWavelengthTask updates the wavelength solution and writes a new detectormap with that correction, but changes in the spatial direction are not currently determined and written to that detectormap. Update the code to provide that correction.
Side note: it may be sensible to rename the task given would correct for both wavelength and spatial directions, but this is less important. |
| Comments |
| Comment by price [ 03/Apr/20 ] |
|
CalibrateWavelengthsTask calibrates the wavelengths. It does not write a new detectorMap: that is done by ReduceArcTask. ReduceArcTask also updates the centers before writing, so I think this is already done. I propose closing this ticket. |
| Comment by price [ 08/Apr/20 ] |
|
No objections, so closing. |