[PIPE2D-500] pfsArm.resample docString claims to return a pfsSpectra not pfsArm Created: 21/Dec/19 Updated: 05/Jan/21 Resolved: 25/Mar/20 |
|
| Status: | Done |
| Project: | DRP 2-D Pipeline |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Story | Priority: | Normal |
| Reporter: | hassan | Assignee: | hassan |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Story Points: | 2 | ||||||||
| Sprint: | 2DDRP-2021 A | ||||||||
| Description |
|
The pfsArm.resample describes returning a pfsSpectra because pfsSpectra is the base class. However this is confusing and it may be the case that the pfsArm->pfsSpectra inheritance needs to be revised. For example, is pfsSpectra necessary? |
| Comments |
| Comment by price [ 05/Mar/20 ] |
|
It's because PfsArm.resample is defined in the base class, as PfsSpectra.resample, which can't know the type of the subclass. PfsSpectra is necessary. Or, at least, it's very helpful to have a common base class for PfsArm and PfsMerged. |
| Comment by price [ 25/Mar/20 ] |
|
Fixed in |