[PIPE2D-499] Make detectorMap.fiberIds and pfsArm.fiberId consistent Created: 21/Dec/19 Updated: 05/Jan/21 Resolved: 06/Mar/20 |
|
| Status: | Done |
| Project: | DRP 2-D Pipeline |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Story | Priority: | Normal |
| Reporter: | hassan | Assignee: | price |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Story Points: | 1 | ||||||||
| Sprint: | 2DDRP-2021 A | ||||||||
| Reviewers: | hassan | ||||||||
| Description |
|
The above members have the same contents but different names. Make them consistent. I propose renaming pfsArm.fiberId to pfsArm.fiberIds |
| Comments |
| Comment by price [ 05/Mar/20 ] |
|
There are a lot of other places where fiberId is used for an array of fiber IDs (e.g., PfsConfig, TargetObservations, PfsFiberTrace). Since your concern is consistency, I'm going to change the DetectorMap.fiberIds to fiberId. |
| Comment by price [ 05/Mar/20 ] |
|
It's almost a search-replace. |
| Comment by price [ 06/Mar/20 ] |
|
Merged to master. |