[PIPE2D-492] Miscellaneous changes to the 2D DRP pipeline Created: 17/Dec/19  Updated: 05/Jan/21  Resolved: 08/Apr/20

Status: Done
Project: DRP 2-D Pipeline
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Story Priority: Normal
Reporter: hassan Assignee: price
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Relates
relates to DAMD-69 Rename pfsSpectra and pfsSpectrum Done
relates to DAMD-71 TargetType should be defined in datam... Done
relates to DAMD-73 PfsArm needs additional information t... Done
relates to PIPE2D-493 SKY HDU is not populated in pfsArm files Done
relates to PIPE2D-497 Update references to lsst.afw.geom to... Done
relates to PIPE2D-498 Revise reference name for detectormap... Done
relates to PIPE2D-499 Make detectorMap.fiberIds and pfsArm.... Done
relates to PIPE2D-500 pfsArm.resample docString claims to r... Done
relates to PIPE2D-502 Correct detectormaps for spatial effe... Done
relates to PIPE2D-503 Support for (re-) using calexps in re... Done
relates to PIPE2D-505 Provide object identifiers for the sky Done
relates to DAMD-70 Define the TargetType in the datamodel Won't Fix
relates to DAMD-72 Provide sky model in datamodel.txt Won't Fix
relates to PIPE2D-501 addFiberTraceSetToMask missing Won't Fix
relates to DAMD-67 Update PfsObject to track input visit... Done
relates to PIPE2D-485 calculate_pfsVisitHash updates Done
relates to DAMD-68 datamodel.txt: include input visits i... Won't Fix
Story Points: 1
Sprint: 2DDRP-2021 A
Reviewers: hassan

 Description   

Following preparations towards the PFS Collaboration Meeting Dec 2019, rhl encountered a number of areas of improvement. His initial rough notes are copied here, but separate tickets based on these notes, and additional related points post-meeting, will be filed as child tickets in due course.

 get("detectormap") – need to decide on good names for the butler
 detMap.fiberIds v. pfsArm.fiberId
 pfsArm.resample docs claim to return a pfsSpectra object not a pfsArm
 afwGeom -> geom change
 What happened to
 stella.utils.addFiberTraceSetToMask
 drpStella.markFiberTraceInMask(ft, mask, ftMask)
 ? Superceded by FiberTrace.getTrace():
 -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
 from pfs.drp.stella import fiberMaskPlane
 def addFiberTraceSetToMask(mask, fiberTraceSet, display=None):
 mask.addMaskPlane(fiberMaskPlane)

for ft in fiberTraceSet:
 ftMask = ft.trace.mask
 calexp.mask[ftMask.getBBox()] |= ftMask

if display:
 display.setMaskPlaneColor(fiberMaskPlane, "GREEN")
 -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
 - It looks as if we're not updating the DetectorMaps' fibre trace *columns* in calibrateWavelength. An old RHL problem, but it may be why the vector plots are weird (or why you built them off arcs!)
 - It looks as if you cannot run reduceArc on calexps. Is there a way to avoid rerunning ISR? The problem is actually in reduceExposure
 pfsSpectra.py and pfsSpectrum.py are confusing names
 The datamodel probably needs to define the values of the targetType enum. They also need to go in the header
 Now we're writing pfsSky the datamodel needs to be fleshed out. Looking at the code I don't understand the model; I'd expect it to be per-fiberId not position
 pfsConfig.objId[pfsConfig.targetType == TargetType.SKY] returns an array of 0s; we need real IDs for skies
 pfsArm files don't seem to fill out the sky HDU


 Comments   
Comment by price [ 05/Mar/20 ]

My understanding is that this is a tracking ticket, and does not contain any actual work to do.

Comment by price [ 03/Apr/20 ]

PIPE2D-502 is the last remaining linked ticket, and I have proposed closing it. I therefore propose closing this also.

Comment by price [ 08/Apr/20 ]

No objections, so closing.

Generated at Sat Feb 10 15:54:01 JST 2024 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.