[PIPE2D-485] calculate_pfsVisitHash updates Created: 12/Dec/19 Updated: 05/Jan/21 Resolved: 13/Feb/20 |
|
| Status: | Done |
| Project: | DRP 2-D Pipeline |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Story | Priority: | Normal |
| Reporter: | price | Assignee: | price |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Story Points: | 1 | ||||||||
| Sprint: | 2DDRP-2021 A | ||||||||
| Reviewers: | rhl | ||||||||
| Description |
|
calculate_pfsVisitHash is unused. Target.calculateVisitHash is what is used in practice for the data. We need to have some simple function (or a class method) that produces the desired value, given a list of visits, so a user can simply get the hash value. Target.calculateVisitHash should sort the list of visits, and remove duplicates. |
| Comments |
| Comment by rhl [ 12/Dec/19 ] |
|
I think this needs to be a free function, and a glance at Target.calculateVisitHash implies that it hashes more than the visits; this isn't what the data model specifies. |
| Comment by price [ 12/Dec/19 ] |
|
rhl writes:
Let's also update the nVisit calculation to be the number of unique visits (so blue and red arms count as one). |
| Comment by price [ 14/Dec/19 ] |
|
This is ready for review. |
| Comment by price [ 13/Feb/20 ] |
|
Merged to master. |