[PIPE2D-476] Combine arcs properly Created: 13/Nov/19  Updated: 05/Jan/21  Resolved: 06/Mar/20

Status: Done
Project: DRP 2-D Pipeline
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Story Priority: Normal
Reporter: price Assignee: price
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: PNG File blue.png     PNG File red.png    
Issue Links:
Relates
relates to PIPE2D-478 Include multi-arc processing in integ... Won't Fix
relates to PIPE2D-482 reduceArc: multiple visits gives poo... Won't Fix
relates to PIPE2D-475 Fix coaddition of spectra in ReduceAr... Done
Story Points: 3
Sprint: 2DDRP-2019 J, 2DDRP-2021 A
Reviewers: hassan

 Description   

`ReduceArcTask` allows processing multiple arcs, but does this by coadding the extracted spectra. That might be fine for combining spectra from the same arc lamp, but to combine spectra from different arc lamps we should be combining the line lists.

Fix this, and expand the integration test to process multiple arcs.

 Comments   
Comment by price [ 25/Feb/20 ]

LOTS more lines now! In processing simulated arcs, getting RMS about 0.25 pixel in the blue and 0.15 pixel in the red (the RMS in the attached plots is 0.220 pixels in blue and 0.154 in red). This needs to improve, certainly on the blue side, but that's a separate issue.

Blue:

Red:

Comment by price [ 25/Feb/20 ]

There are changes to the simulator (fixing arc production, and producing more arcs) and pipeline (combine arcs properly).

Comment by price [ 06/Mar/20 ]

Merged to master.

Generated at Sat Feb 10 15:53:51 JST 2024 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.