[PIPE2D-475] Fix coaddition of spectra in ReduceArcTask.coaddSpectra Created: 13/Nov/19  Updated: 28/Nov/19  Resolved: 14/Nov/19

Status: Done
Project: DRP 2-D Pipeline
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Story Priority: Normal
Reporter: price Assignee: price
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Blocks
blocks PIPE2D-478 Include multi-arc processing in integ... Won't Fix
Relates
relates to PIPE2D-476 Combine arcs properly Done
relates to PIPE2D-482 reduceArc: multiple visits gives poo... Won't Fix
Sprint: 2DDRP-2019 J
Reviewers: naoki.yasuda

 Description   

It's adding instead of taking the average.

 Comments   
Comment by price [ 13/Nov/19 ]

This was a very stupid mistake by me. I've fixed it on tickets/PIPE2D-475 of drp_stella. naoki.yasuda, could you please review the pull request?

I'll release this as soon as I can, but in the mean time the workaround is to specify only a single arc as input to reduceArc.py.

Comment by naoki.yasuda [ 14/Nov/19 ]

I have reviewed the code and I confirmed the reduceArc.py will finish without error when I specify multiple visits as inputs. I think this is fine to merge to master.

Comment by price [ 14/Nov/19 ]

Thanks!

Merged to master.

Comment by price [ 14/Nov/19 ]

Tagged 5.1.6; should be available soon.

Generated at Sat Feb 10 15:53:50 JST 2024 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.