[PIPE2D-43] clean pfsMapper.py of copied functions or make it inherit from HSC mapper Created: 22/Jul/16  Updated: 10/Oct/16  Resolved: 10/Oct/16

Status: Done
Project: DRP 2-D Pipeline
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Story Priority: Major
Reporter: aritter Assignee: aritter
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Sprint: 2014-16
Reviewers: price

 Description   

Currently the PFS mapper is largely copied from HSC mapper. PFS mapper should probably inherit from HSC mapper to minimize copied code

 Comments   
Comment by swinbank [ 20/Sep/16 ]

aritter will discuss this with Paul Price and figure out how to make further progress.

Comment by aritter [ 04/Oct/16 ]

Paul's answer to the question 'What you think would be the best way to avoid copying the functions?':

There are a few options.
1. Subclass HscMapper.
2. Move common functionality into a class that the HscMapper and PfsMapper can both subclass from.
3. I think you can copy the methods directly.
Not sure why you need to flip chips for a spectrograph.
I believe there's also an effort to put some common operations into an obs_base package.

Comment by aritter [ 04/Oct/16 ]

After discussion with RHL we decided to keep the needed copied functions in pfsMapper.py at least for now.
Removed un-used methods from pfsMapper.py. Kept standardizeCalib and std_... as I copied them from HscMapper. Removed static list of amplifiers which were not to be flipped from _flipChipsLR.

Comment by aritter [ 05/Oct/16 ]

See comments and obs_pfs tickets/PIPE2D-43

Comment by aritter [ 10/Oct/16 ]

merged into master

Generated at Sat Feb 10 15:47:40 JST 2024 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.