[PIPE2D-425] Adapt to new header keywords for hexapod positions Created: 22/May/19  Updated: 26/Jul/19  Resolved: 25/Jul/19

Status: Done
Project: DRP 2-D Pipeline
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Story Priority: Normal
Reporter: price Assignee: price
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Story Points: 1
Sprint: 2DDRP-2019 E, 2DDRP-2019 F
Reviewers: cloomis

 Description   

Data from LAM now uses new header keywords for the hexapod positions that we want to capture in the butler.

	Float(name='X', invalid="NaN", units="mm", FITS=('W_ENFCAX', 'ENU_FCA_FOCUS')),
	Float(name='Y', invalid="NaN", units="mm", FITS=('W_ENFCAY', 'ENU_FCA_SHIFT')),
	Float(name='Z', invalid="NaN", units="mm", FITS=('W_ENFCAZ', 'ENU_FCA_DITHER')),

Note that the x,y,z coordinate convention is that of the hexapod, so that:

  • "z" is the shift along the slit (spatial dimension).
  • "y" is the shift perpendicular to the slit (spectral dimension).
  • "x" is focus.

 Comments   
Comment by price [ 22/May/19 ]

Do these changes look reasonable, cloomis?

Comment by hassan [ 25/Jul/19 ]

Pinging cloomis. price: If no feedback by end of this week please merge to master.

Comment by cloomis [ 25/Jul/19 ]

Sorry. I somehow never ever notice review requests.
The changes look sensible. Adding the three offsets to the registry seems useful, assuming that changes in the three rotations are much rarer. I think they will be, that the CCD position and the slit rotations will be rare commissioning alignments, but that the slit offsets will be operational changes.

Comment by price [ 25/Jul/19 ]

Thanks Craig!

Merged to master.

Generated at Sat Feb 10 15:53:01 JST 2024 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.