[PIPE2D-414] reduceExposure.doSubtractContinuum=True does not remove continuum from all fibers Created: 30/Apr/19 Updated: 28/Sep/19 Resolved: 12/Sep/19 |
|
| Status: | Done |
| Project: | DRP 2-D Pipeline |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Bug | Priority: | Normal |
| Reporter: | ncaplar | Assignee: | price |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Attachments: |
|
||||||||||||||||
| Issue Links: |
|
||||||||||||||||
| Story Points: | 4 | ||||||||||||||||
| Sprint: | 2DDRP-2019 E, 2DDRP-2019 H | ||||||||||||||||
| Description |
|
As a concrete example, running the pipeline with reduceExposure.doSubtractContinuum=True for HgAr data taken in February, the continuum is removed from 11 out 16 fibers (see left hand side of the screenshot). This is even thought there are obviously 16 traces in the image (see right hand side of the screenshot) and psfArm has 16 inputs. The gist with the output from constructFiberTrace.py is at https://gist.github.com/nevencaplar/e194f448262b76b4f961fc53a5580015. The full script is pfs_Apr30_HgAr_Feb copy.sh in the folder /home/ncaplar/ReductionScripts/Apr30/. All outputs are in /tigress/ncaplar/ReducedData/HgArFeb_2019/. Mistakes on my part, especially in specifying design file, can not be excluded.... |
| Comments |
| Comment by ncaplar [ 01/May/19 ] |
|
Probably interesting: fiberIds are off by 1 (2 in edge case) between HgAr data and Neon/Krypton data taken in February, even though they have been taken with the same fiber configuration. Observe butler_HgArFeb = Butler("/tigress/ncaplar/ReducedData/HgArFeb_2019/rerun/Apr30_2019/arc") arc_HgArFeb = butler_HgArFeb.get("pfsArm", visit=11749, arm="r", spectrograph=1) arc_HgArFeb.fiberId gives array([619, 586, 524, 517, 463, 417, 400, 339, 307, 288, 254, 222, 191,
110, 62, 31], dtype=uint64)
while butler_NeonFeb = Butler("/tigress/ncaplar/ReducedData/NeonFeb_2019/rerun/Apr30_2019/arc") arc_NeonFeb = butler_NeonFeb.get("pfsArm", visit=12356, arm="r", spectrograph=1) arc_NeonFeb.fiberId gives array([621, 587, 525, 518, 464, 418, 401, 340, 308, 289, 255, 223, 192,
111, 63, 32], dtype=uint64)
|
| Comment by price [ 22/May/19 ] |
|
I'm going to guess that this has been fixed by |
| Comment by ncaplar [ 22/May/19 ] |
|
I will check this today and report back (today). |
| Comment by ncaplar [ 22/May/19 ] |
|
I wanted to test this on the data taken in May, but I hit a problem described in |
| Comment by ncaplar [ 24/May/19 ] |
|
If I do not ingest the updated detectorMap and use the one provided in obs_pfs, the reduction passes and all 10 fibers are recognized. (I now finally understand comment in |
| Comment by price [ 12/Sep/19 ] |
|
Closed by agreement. |