[PIPE2D-410] Illumination of the pupil should be improved Created: 17/Apr/19 Updated: 27/Jan/22 Resolved: 27/Jan/22 |
|
| Status: | Done |
| Project: | DRP 2-D Pipeline |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Task | Priority: | Normal |
| Reporter: | ncaplar | Assignee: | ncaplar |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Attachments: |
|
||||||||||||
| Issue Links: |
|
||||||||||||
| Story Points: | 6 | ||||||||||||
| Description |
|
This ticket is from the series ``Improvements to the PSF 2d modeling, April 2019 brainstorming''. The illumination of the pupil, especially the wide wings has been implemented poorly. At the moment, the illumination is combination of two components: 1. Just top hat with FRD Gaussian broadening and 2. ``Lorentzian'' component that should mimic the wide wings that we see in theta. The actual resulting illumination is then a linear combination of these two components. For vast majority of images the algorithm end in extreme in which there is only ``Lorentzian'' component. In addition, residuals of the defocused images often show rings showing that the illumination of the pupil was not able to capture the wings seen in the data. In short, modeling the illumination of the pupil should be improved. |
| Comments |
| Comment by ncaplar [ 13/Jun/19 ] |
|
I hope that this will done, at least partially, by Brent Belland, once when is able to run my code. |
| Comment by Brent Belland [ 15/Jun/19 ] |
|
I am starting to run the code now. I'll follow with comparing some of my lab data with simulated data. |
| Comment by Brent Belland [ 11/Sep/19 ] |
|
I have analyzed the code and tested it against Cobra-mounted fiber data that I have collected previously; this analysis runs well and the FRD components fit the lab data well, as to be expected. I will continue to work on implementing methods that describe my FRD and misalignment well with minimal time impact. |
| Comment by ncaplar [ 11/Sep/19 ] |
|
Brent Belland Could you describe a bit how much playing around with the parameters which describe the illumination of the pupil in my code did you do to create this residual image? A lot? None at all? |
| Comment by Brent Belland [ 11/Sep/19 ] |
|
Relatively little parameter adjustment for this image, beyond the removal of obscurations as they aren't present in this data. I evaluated over a range of frd_sigma, but within the expected range. I did vary the lorentzian component, but beyond the correlation between lower frd_sigma requiring larger lorentzian component to describe the drop-off, I haven't found a good way to optimize fitting between the two components yet. |
| Comment by ncaplar [ 11/Sep/19 ] |
|
Ok, lets talk a bit more tomorrow, either in the morning or when you come visit. |
| Comment by Brent Belland [ 12/Sep/19 ] |
|
This took me longer than I expected due to some of my scaling code. Running the code against a well-aligned data makes the jagged-tooth like residual mostly disappear (small dips can be seen due to pupil and background subtraction). The offset from 0 at the center has to do with my automated choice of 1.0 for the lab data combined with the curvature seen in the gaussian convolution approximation in the 2D-DRP code. |
| Comment by ncaplar [ 16/Sep/19 ] |
|
Brent Belland Brent I am only looking at this now, sorry for not looking at it immediately. Is this the same lab data as you were showing above? I.e., dd you only change alignment or it this also different data? |
| Comment by Brent Belland [ 17/Sep/19 ] |
|
I apologize for not making this clear - this is data from my alignment tests, with minimal angular misalignment. This is different data from the previous images, where I suspect angular misalignment drove some of the jagged edge residuals in the data. |
| Comment by Brent Belland [ 08/Feb/20 ] |
|
I wanted to follow up this old post with one more update, to cover a question that came up regarding if this fit was good for high FRD data rather than just from the alignment tests. I've uploaded an example figure HighFRD_test that demonstrates that, to within a few percent, the 2D-DRP is reproducing the wider profile drop-offs that I've seen in stressed, non-misaligned fibers. This particular ticket can be closed. |