[PIPE2D-39] Please resolve compiler warnings in Stella Created: 18/Jul/16 Updated: 10/Oct/16 Resolved: 10/Oct/16 |
|
| Status: | Done |
| Project: | DRP 2-D Pipeline |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Bug | Priority: | Major |
| Reporter: | swinbank | Assignee: | aritter |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Attachments: |
|
| Sprint: | 2014-16 |
| Reviewers: | swinbank |
| Description |
|
When I build drp_stella, I see many, many compiler warnings. Most of these are quite trivial (unused variables, comparison of signed vs. unsigned integers), but the very fact there are so many means it's impossible to see if there's anything more sinister going on. Please fix them. |
| Comments |
| Comment by swinbank [ 18/Jul/16 ] |
|
I started doing some cleaning up here, then got bored. My initial effort is on tickets/PIPE2D-39; it's clearly incomplete. |
| Comment by aritter [ 12/Aug/16 ] |
|
In what environment did you compile John? I don't get the warnings you already fixed... |
| Comment by swinbank [ 12/Aug/16 ] |
|
I'm attaching a log of building drp_stella 7a8694af (current master) on: $ uname -a Linux lsst-dev7.ncsa.illinois.edu 3.10.0-327.22.2.el7.x86_64 #1 SMP Thu Jun 23 17:05:11 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux $ g++ --version g++ (GCC) 4.9.2 20150212 (Red Hat 4.9.2-6) It looks like gcc issues a lot more warnings than clang does (in particular, the -Wall option we use enables -Wsign-compare on g++ but not on clang++, which is a shame). |
| Comment by rhl [ 12/Aug/16 ] |
|
Did you run with --filterWarn? If there are warnings that can be fixed we should fix them. If there aren't, file a ticket against sconsUtils to disable the warning. |
| Comment by aritter [ 10/Sep/16 ] |
|
See drp_stella branch tickets/ |
| Comment by aritter [ 10/Oct/16 ] |
|
Merged into master |