[PIPE2D-38] Fix raw input name interpretation according to data model Created: 18/Jul/16  Updated: 09/Aug/16  Resolved: 09/Aug/16

Status: Done
Project: DRP 2-D Pipeline
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Major
Reporter: aritter Assignee: aritter
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Blocks
blocks INFRA-36 Write quick-start guide for Stella Done
Sprint: 2014-15, 2014-16
Reviewers: cloomis

 Description   

Currently Spectrograph and Arm are swapped in obs_pfs/python/lsst/obs/pfs/ingest.py

 Comments   
Comment by aritter [ 18/Jul/16 ]

Swapped 'spectrograph' and 'armNum' in obs_pfs/python/lsst/obs/pfs/ingest.py. See https://github.com/Subaru-PFS/obs_pfs/tree/tickets/PIPE2D-38

Comment by cloomis [ 30/Jul/16 ]

Sorry for having a review larger than the commit...

1. can you add `base=10` to the conversion for visit (on line 49)? It will usually have leading 0s.
2. The actual arm mapping is currently blue=1, red=2, nir=3. 0 is unused. I'll suggest med=4, and reject anything else.
3. reject spectrograph == 0
4. given that is gets used five times, please use maxCcd = 4, etc.
5. as per swinbank, are there test cases?

Comment by aritter [ 02/Aug/16 ]

I don't quite get 1. and 4. Could you please explain cloomis?
2. Adopted
3. Adopted
5. I added tests in obs_pfs/tests/Mapper.py (tickets/PIPE2D-38)

Comment by cloomis [ 03/Aug/16 ]

1. `int(S)` interprets S as an octal number if there are leading 0s. Explicitly calling `int(S, base=10)` is safer for the sequence numbers, which will be '001234' for a while.
4. The `4` (or `8`) which is used several times is always the same quantity: `maxCcds` or some name like that. Make it explicit.

Comment by aritter [ 04/Aug/16 ]

Added base=10 and maxCCDs=4. Ready for re-review...

Comment by cloomis [ 04/Aug/16 ]

OK by me. Feel free to merge.

Comment by aritter [ 09/Aug/16 ]

Merged with master

Generated at Sat Feb 10 15:47:37 JST 2024 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.