[PIPE2D-37] Justify detector geometry constants Created: 16/Jul/16 Updated: 30/Sep/16 Resolved: 30/Sep/16 |
|
| Status: | Done |
| Project: | DRP 2-D Pipeline |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Bug | Priority: | Major |
| Reporter: | swinbank | Assignee: | aritter |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Sprint: | 2014-16 | ||||||||
| Reviewers: | swinbank | ||||||||
| Description |
|
Per |
| Comments |
| Comment by aritter [ 02/Aug/16 ] |
|
https://github.com/Subaru-PFS/datamodel/blob/master/datamodel.txt |
| Comment by aritter [ 03/Aug/16 ] |
|
Added python task to create detector geometry fits files and adopted the constants from RHL's data model (https://github.com/Subaru-PFS/datamodel/blob/master/datamodel.txt). Changes are in obs_pfs tickets/ |
| Comment by swinbank [ 20/Sep/16 ] |
|
Per meeting of 2016-09-19 sending this to me for review. |
| Comment by swinbank [ 20/Sep/16 ] |
|
Several comments on GitHub: https://github.com/Subaru-PFS/obs_pfs/pull/3#pullrequestreview-723183. They're mostly quite minor, but the comments you've added about the detector geometry are quite confusing and therefore undermine the point of the ticket — please fix them up before you merge. |