[PIPE2D-36] make PFS pipeline installable with eups distrib install Created: 09/Jul/16 Updated: 06/Apr/19 Resolved: 07/Mar/19 |
|
| Status: | Done |
| Project: | DRP 2-D Pipeline |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 6.0 |
| Type: | Story | Priority: | Major |
| Reporter: | aritter | Assignee: | price |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Story Points: | 4 | ||||||||
| Sprint: | 2019 B | ||||||||
| Description |
|
As per discussion with Robert and John it is fine for now to install drp_stella, drp_stella_data, and obs_pfs from github, but in the near future we would want the installation be possible via eups distrib install. Note that this doesn't preclude pulling some packages from git, the two systems work well together. We should expect to have a complete copy of the PFS code installed at all major sites and usable by people without having to do an install; eups distrib install provides a way to install updated components into this central copy. Because the PFS dependencies are simple, this is really pretty easy to do (the base LSST stack can be transparently installed as part of this operation). |
| Comments |
| Comment by hassan [ 03/Nov/18 ] |
|
A separate ticket needs to be created for binary distributions to be done. |
| Comment by rhl [ 30/Jan/19 ] |
|
In particular, using a binary installer. We can base this on the LSST one, and just add a few packages of our own. |
| Comment by price [ 01/Feb/19 ] |
|
Having installed the pipeline under eups, and with EUPS_PKGROOT pointing to the LSST distro (https://eups.lsst.codes/stack/redhat/el7/devtoolset-6/miniconda3-4.3.21-10a4fa6|https://eups.lsst.codes/stack/src), this is a simple matter of: pfs@6a5b860c4e22:~ $ eups distrib create --server-dir ~/pfs/eups-server -d tarball pfs_pipe2d 5.0 |
| Comment by price [ 01/Feb/19 ] |
|
I've now added an OSX version as well as the Linux version I created above. You should be able to do:
EUPS_PKGROOT="${EUPS_PKGROOT}|http://tigress-web.princeton.edu/~pprice/pfs-drp-2d"
eups distrib install pfs_pipe2d 5.0
rhl, could you please give this a try? |
| Comment by hassan [ 02/Feb/19 ] |
|
I tested price's suggestion above on my own laptop and ran the pfs_integration_test.sh with success. Note however I needed to run the shebangtron (https://github.com/lsst/shebangtron) prior to running the integration test. |
| Comment by rhl [ 05/Feb/19 ] |
|
If we use the latest version of eups (maybe master – but we can tag) this can be done automatically. We should do this |
| Comment by price [ 05/Feb/19 ] |
|
We're using the newinstall.sh that comes with LSST v16_0. Does that let us choose to use the latest eups version, or does it stick us with whatever was being used back then? |
| Comment by rhl [ 05/Feb/19 ] |
|
I think we replace newinstall. It does very little after installing eups and it needs to set EUPS_PKGROOT which we can do by hand. I can take another look, but I think it's a massively complicates solution to a simple problem. |
| Comment by price [ 05/Feb/19 ] |
|
It may well be, but it's one I don't have to write, maintain or document. |
| Comment by hassan [ 07/Mar/19 ] |
|
The fix Paul described in https://pfspipe.ipmu.jp/jira/browse/PIPE2D-36?focusedCommentId=14827&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14827 with the additional need to run the shebangtron, works as expected. Consider this issue to be resolved based on those points. Additional changes can be raised as separate issues. |