price@MacBook:~/pfs/drp_stella (tickets/PIPE2D-340 %=) $ git sub
commit 7d6271f83f7168d0050e60a3e697da0a3f4ef99e
Author: Paul Price <price@astro.princeton.edu>
Date: Tue Feb 19 15:26:06 2019 -0500
DetectorMap: remove testing Ctor
I made this Ctor while trying to figure out problems with pybind;
looks like I forgot to remove it when I was done.
include/pfs/drp/stella/DetectorMap.h | 9 ---------
1 file changed, 9 deletions(-)
commit b2306b211049175b44e4bc40ceaaac19a8ff3de6
Author: Paul Price <price@astro.princeton.edu>
Date: Wed Feb 20 14:11:17 2019 -0500
DetectorMap: convert DX,DY,DFOCUS to properties instead of enum
Having them as an enum requires casting them every time we want to use
them for indexing, which is their primary purpose. Instead, as
static readonly properties, they are of the correct type for indexing.
python/pfs/drp/stella/detectorMap.cc | 11 ++++++-----
tests/test_DetectorMap.py | 6 ++----
2 files changed, 8 insertions(+), 9 deletions(-)
commit d136792e6f80ac17b04b3b14139bdc4ea3040286
Author: Paul Price <price@astro.princeton.edu>
Date: Wed Feb 20 13:02:35 2019 -0500
add test for DetectorMap slitOffsets
tests/test_DetectorMap.py | 99 +++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 99 insertions(+)
commit 18d288ba0f91ad2e6997df63b9ce69df6429eebc
Author: Paul Price <price@astro.princeton.edu>
Date: Wed Feb 20 15:05:37 2019 -0500
add SlitOffsetsConfig
This allows configuring slit offsets through a Config.
python/pfs/drp/stella/detectorMapContinued.py | 69 ++++++++++++++++++++++++++-
tests/test_DetectorMap.py | 54 +++++++++++++++++++++
2 files changed, 122 insertions(+), 1 deletion(-)
commit 9a50145cce7b8281a5cd6bd02f962fcf5b806c0b (HEAD -> tickets/PIPE2D-340, origin/tickets/PIPE2D-340)
Author: Paul Price <price@astro.princeton.edu>
Date: Wed Feb 20 15:22:01 2019 -0500
constructFiberTrace: allow manual application of slitOffsets to detectorMap
This allows the user to modify the slitOffsets of the detectorMap
by specifying them in the config.
python/pfs/drp/stella/constructFiberTraceTask.py | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)