[PIPE2D-316] Demonstrate arm merging Created: 26/Jan/19  Updated: 14/Mar/20  Resolved: 14/Mar/19

Status: Done
Project: DRP 2-D Pipeline
Component/s: None
Affects Version/s: None
Fix Version/s: 6.0

Type: Task Priority: Normal
Reporter: hassan Assignee: price
Resolution: Done Votes: 0
Labels: 2DDRP-V5
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: PNG File coadd.png     PNG File merged_fixed.png     PNG File merged.png     PNG File merge.png    
Issue Links:
Blocks
is blocked by PIPE2D-344 Implement arm merging Done
is blocked by SIM2D-94 Simulator should accept a PfsConfig i... Done
is blocked by SIM2D-99 Build blue-arm data in simulator Done
is blocked by PIPE2D-335 Provide dichroic transmission curves Done
is blocked by SIM2D-93 Obtain Blue and NIR spot data Done
is blocked by SIM2D-104 Generate darks, biases, quartz for ar... Done
Relates
relates to PIPE2D-523 Demonstrate R, B and NIR arm merging Done
relates to PIPE2D-381 Leave lamp response in the master flat Won't Fix
Story Points: 1
Epic Link: Arm merging
Sprint: 2019 B, 2DDRP-2019 C
Reviewers: hassan

 Description   

Once SIM2D-93 has been implemented, the DRP pipeline should be updated if necessary to demonstrate the merging of arms.

It is already understood that an initial implementation for arm merging is currently in place.

The accuracy of the merging operation (and a method for determining the accuracy) need to be provided to this ticket. This is TBD.



 Comments   
Comment by price [ 01/Feb/19 ]

With some hacking, I can build blue-side images, which demonstrates that the spot data (SIM2D-93) works.
To do this properly, we need:

  • Transmission curves
  • Verify blue detector size
  • Blue bias frames
Comment by price [ 09/Feb/19 ]

After a bunch of mucking around, I managed to process both blue and red data through mergeArms.py. An example pfsMerged file is plotted above. There are a bunch of problems evident in the plot, but the main thing to notice is that the blue and red arms have been merged.

I'll push some changes to ticket branches once I've cleaned them up.

Comment by price [ 09/Feb/19 ]

Currently the fiber assignments don't match between the blue and red images. I would therefore like to delay adding blue data to the integration test until we can get the simulator properly producing coordinated blue and red images (SIM2D-99 + SIM2D-94).

Comment by price [ 05/Mar/19 ]

merge.png shows that merging works, but the continuum is not continuous over the merge region (~650nm). I believe this is due to an incorrect normalisation in the flat field and/or fiber trace.

Comment by rhl [ 08/Mar/19 ]

How do we know what's right here?  Should we generate some fibres with bright objects with simple spectra (e.g. constant nu I_nu;  power laws; black bodies) to help assess our success here.

Comment by price [ 08/Mar/19 ]

That's what I'm doing right now.

Comment by price [ 08/Mar/19 ]

coadd.png: two simulated exposures each with red+blue arms, run through the pipeline, and this is the resultant coadd spectrum (black) compared with the input simulator spectrum (constant F_nu @ 22 mag; red). The sky line subtraction is awful because it’s a braindead placeholder algorithm, but the continuum level looks about right. Looks like we've fixed the discontinuities!

from lsst.daf.persistence import Butler
butler = Butler("INTEGRATION/rerun/integration/pipeline")
coadd  = butler.get("pfsCoadd", catId=7, tract=0, patch="0,0", objId=3, numExp=4, expHash=0x1eab2e92)
fig, axes = coadd.plot(plotSky=False, plotErrors=False, show=False)
axes.axhline(3631e9*10**(-0.4*22.0), color="r")
fig.show()
Comment by price [ 08/Mar/19 ]

merged_fixed.png: demonstrates that the merged spectrum (pfsMerged: single exposure) is good too. The higher orange line is the flux standard (18 mag), while the lower lines are the science objects (22 mag).

from lsst.daf.persistence import Butler
butler = Butler("INTEGRATION/rerun/integration/pipeline")
merged  = butler.get("pfsMerged", expId=32, arm="r")
fig, axes = merged.plot()
Comment by price [ 08/Mar/19 ]

I'm finally happy with this. hassan, would you please take a look? This ticket was the home for simulator work as well, so there are a bunch of changes in several packages.

Comment by hassan [ 14/Mar/19 ]

Ok overall. Separate tickets can be raised later on points that could be missed.

Comment by price [ 14/Mar/19 ]

Merged to master.

Generated at Sat Feb 10 15:50:57 JST 2024 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.