[PIPE2D-298] Record throughput in FiberTrace Created: 19/Oct/18  Updated: 06/Nov/18  Resolved: 06/Nov/18

Status: Done
Project: DRP 2-D Pipeline
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Story Priority: Normal
Reporter: price Assignee: price
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Relates
relates to PIPE2D-290 Fix normalisation of fibers in flats Done
Reviewers: hassan

 Description   

PIPE2D-290 ("Fix normalisation of fibers in flats") corrected the fibers so they are all calibrated to the same spectrum. However, we want to apply this kind of calibration on a more frequent timescale than on which we make the flat-fields. We can measure it when we construct the FiberTrace, store it in the FiberTrace, and apply it when we extract.



 Comments   
Comment by price [ 25/Oct/18 ]

This also involved some refactoring and the addition of a front-end to the plotting stuff I introduced earlier.

price@Pauls-MacBook-Pro:~/pfs/drp_stella (tickets/PIPE2D-298=) $ git sub
commit 4c46191aea4a8101caeac058a7c2c39a22199274
Author: Paul Price <price@astro.princeton.edu>
Date:   Thu Oct 18 15:46:22 2018 -0400

    refactor calib construction using base class
    
    The ConstructFiberFlatTask and ConstructFiberTraceTask are similar,
    but different. The relation has been expressed as the first inheriting
    from the second, but it's not really an 'is a' relationship. Instead,
    have them share a base class that does the common operations.

 python/pfs/drp/stella/constructFiberFlatTask.py  |  91 ++-----------
 python/pfs/drp/stella/constructFiberTraceTask.py | 163 ++++------------------
 python/pfs/drp/stella/constructSpectralCalibs.py | 165 +++++++++++++++++++++++
 3 files changed, 199 insertions(+), 220 deletions(-)

commit c5fa627391fbee9266137c7b572054820d2a4020
Author: Paul Price <price@astro.princeton.edu>
Date:   Tue Oct 23 17:23:16 2018 -0400

    Add plotArm.py to plot spectra from a PfsArm

 bin.src/plotArm.py | 44 ++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 44 insertions(+)

commit d151e21c16cb31b93e3b78a50a83246e61c998c8
Author: Paul Price <price@astro.princeton.edu>
Date:   Tue Oct 23 17:48:00 2018 -0400

    constructFiberFlat: pull averaging of spectra into base class
    
    We will use it in constructFiberTrace as well.

 python/pfs/drp/stella/constructFiberFlatTask.py  | 16 +----------
 python/pfs/drp/stella/constructSpectralCalibs.py | 34 ++++++++++++++++++++++++
 2 files changed, 35 insertions(+), 15 deletions(-)

commit 9d3442d708c9831ac37d88cbbdc5a4fe8f6663a1 (HEAD -> tickets/PIPE2D-298, origin/tickets/PIPE2D-298)
Author: Paul Price <price@astro.princeton.edu>
Date:   Tue Oct 23 17:50:01 2018 -0400

    constructFiberTrace: scale trace to match spectra
    
    If the throughput of the fibers varies, we want the trace to track that.
    This is already corrected in the flat-field, but we expect that it may
    change on shorter durations than the imaging flat.

 python/pfs/drp/stella/constructFiberTraceTask.py | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
Comment by price [ 06/Nov/18 ]

Merged to master after changes approved on GitHub.

Generated at Sat Feb 10 15:50:43 JST 2024 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.