[PIPE2D-295] Fix use of GitHub API Created: 04/Oct/18  Updated: 25/Oct/18  Resolved: 25/Oct/18

Status: Done
Project: DRP 2-D Pipeline
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Story Priority: Normal
Reporter: price Assignee: price
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Reviewers: cloomis

 Description   

We often get in Travis:

...
scons: done building targets.
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (22) The requested URL returned error: 403 Forbidden
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (22) The requested URL returned error: 403 Forbidden
The command '/bin/bash -lc . ${LSST_DIR}/loadLSST.bash  && setup lsst_distrib  && export -f setup  && . /opt/rh/devtoolset-${DEVTOOLSET}/enable  && ${PFS_DIR}/build_pfs.sh $INSTALL_PFS_ARGS -t current  && ( find ${PFS_DIR} -exec strip --strip-unneeded --preserve-dates {} +       > /dev/null 2>&1 || true )  && ( find ${PFS_DIR} -maxdepth 5 -name tests -type d -exec rm -rf {} +       > /dev/null 2>&1 || true )  && ( find ${PFS_DIR} -maxdepth 5 -path "*doc/html" -type d -exec rm -rf {} +       > /dev/null 2>&1 || true )  && ( find ${PFS_DIR} -maxdepth 5 -name src -type d -exec rm -rf {} +       > /dev/null 2>&1 || true )' returned a non-zero code: 22

Note the 403 Forbidden, which is coming from a curl command using the GitHub API. I believe we are exceeding a rate limit in the GitHub API (possibly a limit shared by everyone on Travis?). Instead, we can dump the use of the GitHub API and just download the repo with git.



 Comments   
Comment by price [ 04/Oct/18 ]

cloomis, do you see any problems with this? The only thing I can think of is that eups product versions are named after branches rather than the commit SHA, but I don't think that's too bad since this is principally used by Docker under which there's only one version anyway, and if you really care about the version you'll use a tag.

Comment by price [ 25/Oct/18 ]

hassan suggested I merge this since it's small and blocking the robust use of Travis for other issues.
cloomis, we can still revert or clean up the changes if you have any problems with them; please let me know.

Generated at Sat Feb 10 15:50:41 JST 2024 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.