[PIPE2D-280] Clean up Created: 01/May/18  Updated: 16/Aug/18  Due: 23/Jul/18  Resolved: 16/Aug/18

Status: Done
Project: DRP 2-D Pipeline
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Story Priority: Normal
Reporter: price Assignee: price
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Relates
relates to DAMD-30 Please do not use LSST module in pfsA... Won't Fix
Reviewers: hassan

 Description   
  • Remove obs_pfs dependency on drp_stella.
  • Remove datamodelIo functions.
  • Purge unit tests of things that are in the integration tests.
  • Review remaining drp_stella unit tests so they are useful.
  • Update integration tests to run on modern example LAM data.


 Comments   
Comment by price [ 08/May/18 ]

rhl requests: "During your cleanup, can you fix the run methods to accept unpacked data (i.e. no DataRef s)? Add runDataRef to do the unpacking".
And: "We need to move all the functional code out of the CmdLineTask s. So e.g. ReduceArcTask should either not be a CmdLineTask, or it needs to defer to a "real" task. The exact level of splitting is TBD."

Comment by price [ 08/May/18 ]

All Task s should return a Struct in preference to a single value.

Fix IdentifyLinesTask._DefaultName.

lineList should be lineListFilename.

Comment by price [ 14/Jul/18 ]

hassan, I'm sending this to you as reviewer because the changes are so extensive (several thousands of lines) I don't know how it should be reviewed. I suggest that, rather than one person looking at every line changed, any stakeholders (including rhl and cloomis) have a look at revised C++ APIs, and then someone looks over the python changes. Or we could just say that this is what we want to work off going forward, I merge and any complaints are resolved as future tickets.
I've verified that the pipeline produces similar results before and after this change (I say "similar" rather than "identical" because there are some tiny algorithmic fixes to fitting rejection somewhere that had a small, apparently positive effect; there's also a change to the wavelength fitting in its own commit, but I'm not including that in the comparison).

I haven't yet updated the integration test, but I want to get the code moving towards merge.

Comment by price [ 14/Jul/18 ]

For drp_stella, GitHub says "5,448 additions and 7,429 deletions."

Comment by hassan [ 17/Jul/18 ]

Ok let's see if @rhl and @cloomis at least have time this week to review. I think our outstanding unit test discussion is useful for the next time, as such tests are very useful tools to help minimize reviews by individuals.

Comment by price [ 16/Aug/18 ]

Merged to master after obtaining consensus on Slack.

Generated at Sat Feb 10 15:50:31 JST 2024 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.