[PIPE2D-280] Clean up Created: 01/May/18 Updated: 16/Aug/18 Due: 23/Jul/18 Resolved: 16/Aug/18 |
|
| Status: | Done |
| Project: | DRP 2-D Pipeline |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Story | Priority: | Normal |
| Reporter: | price | Assignee: | price |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Reviewers: | hassan | ||||||||
| Description |
|
| Comments |
| Comment by price [ 08/May/18 ] |
|
rhl requests: "During your cleanup, can you fix the run methods to accept unpacked data (i.e. no DataRef s)? Add runDataRef to do the unpacking". |
| Comment by price [ 08/May/18 ] |
|
All Task s should return a Struct in preference to a single value. Fix IdentifyLinesTask._DefaultName. lineList should be lineListFilename. |
| Comment by price [ 14/Jul/18 ] |
|
hassan, I'm sending this to you as reviewer because the changes are so extensive (several thousands of lines) I don't know how it should be reviewed. I suggest that, rather than one person looking at every line changed, any stakeholders (including rhl and cloomis) have a look at revised C++ APIs, and then someone looks over the python changes. Or we could just say that this is what we want to work off going forward, I merge and any complaints are resolved as future tickets. I haven't yet updated the integration test, but I want to get the code moving towards merge. |
| Comment by price [ 14/Jul/18 ] |
|
For drp_stella, GitHub says "5,448 additions and 7,429 deletions." |
| Comment by hassan [ 17/Jul/18 ] |
|
Ok let's see if @rhl and @cloomis at least have time this week to review. I think our outstanding unit test discussion is useful for the next time, as such tests are very useful tools to help minimize reviews by individuals. |
| Comment by price [ 16/Aug/18 ] |
|
Merged to master after obtaining consensus on Slack. |