continuum-image.png
continuum.png
[PIPE2D-277] Continuum subtract arc spectra in 2-d Created: 20/Apr/18 Updated: 04/May/18 Resolved: 04/May/18 |
|
| Status: | Done |
| Project: | DRP 2-D Pipeline |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Story | Priority: | Normal |
| Reporter: | rhl | Assignee: | price |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Attachments: |
continuum-image.png
continuum.png
|
| Reviewers: | rhl |
| Description |
|
The HgAr lamp spectra that we are taking at LAM (and maybe all HgAr spectra!) have what looks like a significant continuum. While not important for wavelength calibrations, this matters for PSF determination. We think that all the spectra show this, but for definiteness: Neven has looked at 8603, 8604, 8605 (all in focus), are 859* are also in focus, but dithered, and for instance for defocus is 8564.
The way to fix this is to do an extraction, mask the lines and fit the continuum, then use something like the self.debugInfo.residuals_frame code in reduceArcTask.py (the workhorse is ft.getReconstructed2DSpectrum(spec)) |
| Comments |
| Comment by cloomis [ 20/Apr/18 ] |
|
And yes, 8937 etc. also show it, and will have the same configuration as the other 2017-12-20 reference data. |
| Comment by price [ 28/Apr/18 ] |
|
I've got this working. The only thing I'm concerned about is that the fiber trace appears to be off horizontally (as seen by an asymmetric horizontal profile through the continuum-subtracted image), but I don't think that has anything to do with this feature. |
| Comment by price [ 28/Apr/18 ] |
|
Based my work off |
| Comment by price [ 28/Apr/18 ] |
|
OK, rhl, I think this is ready for you. It's based on |
| Comment by price [ 01/May/18 ] |
|
Taking this back, as I've just discovered that the tests in drp_stella are not passing. These tests have not been firing under Travis because drp_stella_data was only being installed for the integration test, so was unavailable at the time drp_stella was being built. |
| Comment by price [ 04/May/18 ] |
|
Merged to master without detailed review (though I did drop the commit rhl questioned). The reason for this that there's a lot of cleanup coming, and it will be easier to simply review the state of the code after the cleanup than to approve every change piecemeal. |