[PIPE2D-276] Fix integration test Created: 11/Apr/18 Updated: 03/Nov/18 Resolved: 03/Nov/18 |
|
| Status: | Won't Fix |
| Project: | DRP 2-D Pipeline |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Story | Priority: | Normal |
| Reporter: | price | Assignee: | price |
| Resolution: | Won't Fix | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Description |
|
The integration test is currently broken. RuntimeError: Unable to retrieve dark for {'visit': 103, 'dateObs': '2016-11-11', 'site': 'F', 'category': 'A', 'arm': 'r', 'spectrograph': 1}: No locations for get: datasetType:dark dataId:DataId(initialdata={'visit': 103, 'dateObs': '2016-11-11', 'site': 'F', 'category': 'A', 'arm': 'r', 'spectrograph': 1}, tag=set()) |
| Comments |
| Comment by price [ 11/Apr/18 ] |
|
https://travis-ci.org/Subaru-PFS/pfs_pipe2d/builds/364685890 |
| Comment by cloomis [ 11/Apr/18 ] |
|
Cough. |
| Comment by price [ 11/Apr/18 ] |
|
This has fixed Travis. cloomis, could you please sign off on this, as I've explicitly changed one of your recent changes?
price@neverland:~/pfs/obs_pfs (tickets/PIPE2D-276=) $ git sub-patch
commit 81534a0dc7f1737225d0332db82075918e7a04bd
Author: Paul Price <price@astro.princeton.edu>
Date: Tue Apr 10 13:29:09 2018 -0400
config: increase number of permitted CRs
Real spectrograph images are going to have many more cosmic rays than
simulated images; the darks in the integration test certainly do.
Restore the nCrPixelMax back to what it was.
diff --git a/config/pfs.py b/config/pfs.py
index dbd9ce5..06b1349 100644
--- a/config/pfs.py
+++ b/config/pfs.py
@@ -26,7 +26,7 @@ if hasattr(config, 'repair'):
config.repair.interp.modelPsf.defaultFwhm = 1.75
config.repair.cosmicray.cond3_fac = 4
config.repair.cosmicray.cond3_fac2 = 1
- config.repair.cosmicray.nCrPixelMax = 60000
+ config.repair.cosmicray.nCrPixelMax = 5000000
config.repair.cosmicray.minSigma = 10.0
config.repair.cosmicray.min_DN = 500.0
|
| Comment by cloomis [ 11/Apr/18 ] |
|
Good. Done. |
| Comment by hassan [ 03/Nov/18 ] |
|
Does not appear to be a problem any longer. |