[PIPE2D-233] fix PolyFit accuracy Created: 28/Jul/17 Updated: 01/Aug/17 Resolved: 01/Aug/17 |
|
| Status: | Done |
| Project: | DRP 2-D Pipeline |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Story | Priority: | Normal |
| Reporter: | aritter | Assignee: | aritter |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Story Points: | 2 | ||||||||
| Description |
|
Changing everything from double to float broke the PolyFit function. Please fix that |
| Comments |
| Comment by aritter [ 29/Jul/17 ] |
|
I have pushed the changes to master however there are no additional tests as the plotting procedures which showed systematics in the RMS of the identified lines are in |
| Comment by swinbank [ 29/Jul/17 ] |
|
We discussed this at our meeting of 2017-07-28. We agreed that the fitter ought to be using Chebyshevs rather than straight polynomials. Please file another ticket to fix this before merging this work. |
| Comment by rhl [ 29/Jul/17 ] |
|
Minor comments on GitHub |