[PIPE2D-232] obs_pfs writes a test pfsFiberTrace file with the wrong name Created: 28/Jul/17 Updated: 28/Jul/17 Resolved: 28/Jul/17 |
|
| Status: | Done |
| Project: | DRP 2-D Pipeline |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Story | Priority: | Normal |
| Reporter: | rhl | Assignee: | rhl |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Reviewers: | price |
| Description |
|
tests/PfsFiberTrace.py hard codes a filename that is controlled by the data model. Please don't do this. At the same time, write the file to a temporary directory and clean up afterwards. It currently written to (and left in) .. |
| Comments |
| Comment by rhl [ 28/Jul/17 ] |
|
This just cleans up a test (and removes some now incorrect hardcoding). Feel free to just push "reviewed" if you're busy. |
| Comment by price [ 28/Jul/17 ] |
|
I suggest squashing the two commits. |
| Comment by rhl [ 28/Jul/17 ] |
|
I think I'll keep the two changesets (and Paul agreed); the first one solves the fatal error, while the second one cleans up the test (and prevents files with old names lying around to confuse me) Merged. |