[PIPE2D-216] make FiberTrace::extractFromProfile complain about NaNs or to deal with them Created: 29/Jun/17  Updated: 03/Nov/18  Resolved: 03/Nov/18

Status: Won't Fix
Project: DRP 2-D Pipeline
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Story Priority: Normal
Reporter: aritter Assignee: Unassigned
Resolution: Won't Fix Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Relates
relates to PIPE2D-165 Replace {{cout <<}} and {{print}} wit... Won't Fix
Story Points: 2

 Description   

Currently FiberTrace::extractFromProfile crashes with the message CFits::GCF: ERROR: a too large, ITMAX too small in GCF if NaN s are present in the image, as can happen after the ISR task if the pixels are saturated (maybe Cosmics, too?). Please make the error message more telling, check for Nan s before running the procedure, and make it complain about or fix the problem. Originally the procedure ignored pixels which were masked as 0 while 1 meant a good pixel. I'm not sure how much of that is left.
CFits:: is definitely a remnant from old times and should be replaced with the actual namespace . In general all the debug messages
{{ #ifdef _DEBUG_EXTRACTFROMPROFILE__
cout << "message << endl;
#endif }}
should be replaced with LSST::log messages, but this also part of ticket PIPE2D-165.



 Comments   
Comment by rhl [ 29/Jun/17 ]

While making things robust is always good, we do not permit NaNs in images. I assume that you're using the mask planes to decide which pixels to use (but that should not be needed to avoid NaN woes)

Comment by hassan [ 03/Nov/18 ]

Will revisit this issue if this appears again once we have the SIM2D + 2D DRP working.

Generated at Sat Feb 10 15:49:39 JST 2024 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.