[PIPE2D-207] Run coverage tools and remove *all* unused code Created: 22/Jun/17 Updated: 27/Jul/17 Resolved: 27/Jul/17 |
|
| Status: | Done |
| Project: | DRP 2-D Pipeline |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Epic | Priority: | Major |
| Reporter: | rhl | Assignee: | Unassigned |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Epic Name: | Remove unused code from drp_stella | ||||||||
| Description |
|
There's a lot of unused code in drp_stella and it needs to be removed. Let us start by running a python coverage tool on all the "live" command line tasks, and remove all code that doesn't get used (subject to some sort of sanity test). This should cover unused swig wrappers as well as unused python code. Then, after that, run a C++ coverage tool (e.g. tcov) and remove all C++ that isn't used. |
| Comments |
| Comment by rhl [ 23/Jul/17 ] |
|
Started on this. Removed unused python and merged. If we need to remove more code, please call the branch tickets/ |
| Comment by rhl [ 23/Jul/17 ] |
|
Removed LinFitBevingtonEigen on branch tickets/ |
| Comment by rhl [ 27/Jul/17 ] |
|
Removed makeNormFlatFiberTrace and getRawPointer on branch tickets/ N.b. didn't remove fiberTraceCoordinatesRelativeTo as it's used internally, and ccdToFiberTraceCoordinates is used to test it (both are bound to python). These need to go as part of FiberTrace cleanup. |
| Comment by rhl [ 27/Jul/17 ] |
|
merged |