[PIPE2D-195] In .cc files please change return value of {{bool set...(...)}} functions to void if they can't return false Created: 08/Jun/17 Updated: 16/Aug/18 Resolved: 16/Aug/18 |
|
| Status: | Won't Fix |
| Project: | DRP 2-D Pipeline |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Story | Priority: | Major |
| Reporter: | aritter | Assignee: | aritter |
| Resolution: | Won't Fix | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Story Points: | 1.5 | ||||||||
| Description |
|
Some set... functions in .cc files have the return type bool, some have void. Some throw an error if the position where the object should be set in a vector is invalid, some return false. Sometimes the returned bool is checked whether it's true or false. Some functions, like e.g. Spectra::setSpectrum return bool even though they cannot return false but throw an error instead. Please make all this consistent. |
| Comments |
| Comment by price [ 16/Aug/18 ] |
|
This was done in |