[PIPE2D-182] Please factor the I/O in reduceArc(RefSpec)Task into separate functions Created: 24/Mar/17 Updated: 26/Jun/17 Resolved: 26/Jun/17 |
|
| Status: | Done |
| Project: | DRP 2-D Pipeline |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Story | Priority: | Major |
| Reporter: | aritter | Assignee: | aritter |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||
| Story Points: | 2 | ||||||||||||
| Sprint: | 2014-17 | ||||||||||||
| Reviewers: | swinbank | ||||||||||||
| Description |
|
tests/FiberTraces.py, tests/Spectra.py and reduceArc(RefSpec)Task.py currently read the files RedFiberPixels, reference spectrum, and line list via copied code blocks. Please factor these code blocks out as individual functions and use these functions to read the files. The same for writing the pfsArm file in reduceArc(RefSpec)Task.py |
| Comments |
| Comment by swinbank [ 17/Jun/17 ] |
|
Looks basically fine. Minor comments on the PR. I think it'd be nice to change readWavelengthFile to return something more idiomatic than a dict, but otherwise good to merge. |
| Comment by aritter [ 26/Jun/17 ] |
|
merged into master |