[PIPE2D-1681] fluxCalQA: normalize pfsMerged.flux and anonymize plot Created: 28/Mar/25 Updated: 29/Mar/25 Resolved: 29/Mar/25 |
|
| Status: | Done |
| Project: | DRP 2-D Pipeline |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Task | Priority: | Normal |
| Reporter: | Masayuki Tanaka | Assignee: | Masayuki Tanaka |
| Resolution: | Done | Votes: | 0 |
| Labels: | flux-calibration | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Epic Link: | flux calibration |
| Reviewers: | Kiyoto Yabe |
| Description |
|
pfsMerged.flux is not divided by exptime and thus the median of (imag_pfsMerged - imag_PS1) varies with exposure time. This has to be fixed. Also, for open-use programs, we want to anonymize the plot (e.g., mask coordinates, etc) in some occasions. Implement the anonymization option. I know it is not a good manner to implement two features with a single ticket. But, I want to make a quick update for the on-going run and I hope people are not too upset... |
| Comments |
| Comment by Masayuki Tanaka [ 28/Mar/25 ] |
|
Kiyoto Yabe, could you review the ticket branch? The code overall is quite ugly, but I think it works. |
| Comment by Kiyoto Yabe [ 29/Mar/25 ] |
|
Thank you! Could you open the pull request? |
| Comment by Masayuki Tanaka [ 29/Mar/25 ] |
|
I fixed the doAnonymize issue and made a pull request. I think the default should be doAnonymize=True to be conservative. We will use the code both for developers and users. If we set the default to False, run the code, and share the plots with the user (by mistake), then we will be in trouble. The other way around is no problem; we just have to run the code again with the option set to False for developers. |
| Comment by Masayuki Tanaka [ 29/Mar/25 ] |
|
Merged. Thank you for reviewing. |