[PIPE2D-163] split up tests for PolyFit into several small tests Created: 03/Mar/17  Updated: 03/Nov/18  Resolved: 03/Nov/18

Status: Won't Fix
Project: DRP 2-D Pipeline
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Story Priority: Major
Reporter: aritter Assignee: aritter
Resolution: Won't Fix Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Relates
relates to PIPE2D-109 Include sigma clipping in wavelength ... Done
relates to PIPE2D-114 Apply clean-ups in PIPE2D-109 Done
Story Points: 4

 Description   

According to the reviewer's comments on PIPE2D-114:

You have a single giant function which tests a number of different calls to PolyFit. Rather than doing that, you ought to have a number of short unit tests, each of which tests a single call.

Ideally, each of the unit tests would be written in Python. However, I understand that the full PolyFit interface is not exposed to Python, so this is impractical. That leaves you with two choices:

Use a C++-based test harness. The one in use in LSST is Boost::Test. For example, see these tests in afw.
Write individual test functions in C++ then expose each one to Python by wrapping it separately using Swig.
Either of those approaches is adequate. What you've got now isn't.



 Comments   
Comment by hassan [ 03/Nov/18 ]

Duplicates PIPE2D-192

Generated at Sat Feb 10 15:49:06 JST 2024 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.