[PIPE2D-147] Solve PfsMapper._extractDetectorId contradiction Created: 19/Jan/17 Updated: 08/Jun/17 Resolved: 08/Jun/17 |
|
| Status: | Done |
| Project: | DRP 2-D Pipeline |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Story | Priority: | Major |
| Reporter: | aritter | Assignee: | aritter |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Story Points: | 1 | ||||||||
| Sprint: | 2014-16 | ||||||||
| Reviewers: | price | ||||||||
| Description |
|
Currently the detectorId in the PfsMapper goes from 1 to 12 while in the camera mapper the detector IDs go from 0 to 11. We need to agree on one definition and fix the other one. I assume this won't need to get added to the datamodel as it is hidden from the user. |
| Comments |
| Comment by swinbank [ 19/Jan/17 ] |
|
Adding this to current sprint since it's blocking |
| Comment by swinbank [ 31/Jan/17 ] |
|
Decision at meeting of 2017-01-30: 0-11. |
| Comment by rhl [ 07/Jun/17 ] |
|
See review comments; otherwise good to merge. Please remove all white-space-only changes before merging. Next time, please review your changesets for such changes and remove them before submitting for review. |
| Comment by rhl [ 07/Jun/17 ] |
|
OK to merge. There are some C++ comments in the review; please file as new issues rather than addressing them here |
| Comment by aritter [ 08/Jun/17 ] |
|
Merged into master |