[PIPE2D-1415] Please add missing lines for the HgCd lamps Created: 04/Apr/24 Updated: 19/Jul/24 Resolved: 19/Jul/24 |
|
| Status: | Done |
| Project: | DRP 2-D Pipeline |
| Component/s: | obs_pfs |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Story | Priority: | Normal |
| Reporter: | rhl | Assignee: | Wilfred Gee |
| Resolution: | Done | Votes: | 0 |
| Labels: | EngRun | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Attachments: |
106863.png
106863_zoom.png
tmp - 2024-04-03T143631.956.png
v106863-line-lists-spatial.png
v106863-line-lists-wavelength.png
|
| Reviewers: | price |
| Description |
|
Looking at HgCd arcs we are missing quite a few lines in the HgCd.txt file (see I checked, and I don't think that the lines are from the Ar carrier, but I could be wrong. There are some weak lines which extend the blue coverage, but it isn't clear how useful they are. |
| Comments |
| Comment by Kiyoto Yabe [ 13/Apr/24 ] |
|
I corss-matched detected lines with Hg+Cd line list from the NIST database. One line at ~1040nm, however, is not on the list. |
| Comment by Wilfred Gee [ 30/May/24 ] |
|
I created this PR that has a naive combination of the `Hg.txt` and `HgCd.txt` files.
|
| Comment by rhl [ 31/May/24 ] |
|
I don't think a naïve merge is that useful, it needs to be validated by looking carefully at all the lines and looking for blends and missing lines. But it's probably a great start! And remember that we use vacuum wavelengths! |
| Comment by Wilfred Gee [ 31/May/24 ] |
|
Christian Kragh Jespersen revised the list and I've asked price to review it. And confirm that we are using the vacuum wavelengths. |
| Comment by price [ 31/May/24 ] |
|
The values from Hg.txt should be vacuum wavelengths. |
| Comment by Wilfred Gee [ 16/Jul/24 ] |
|
Output from running reduceExposure.py with new line lists vs old, with 38080 line centroids vs 5950. All other processing parameters were the same. We have dropped the one HgII line from the new list at 734.85320 228.57 HgII 0. I'm assuming this was intentional? Christian Kragh Jespersen < root INFO: Running: /work/stack_INFRA-312/stack/miniconda3-py38_4.9.2-3.0.0/Linux64/drp_stella/w.2024.17a/bin/reduceExposure.py /work/drp --calib /work/drp/CALIB --rerun wtg/PIPE2D-1415-03 --id visit=106863 arm=b^r^n^m > root INFO: Running: /work/stack_INFRA-312/stack/miniconda3-py38_4.9.2-3.0.0/Linux64/drp_stella/w.2024.17a/bin/reduceExposure.py /work/drp --calib /work/drp/CALIB --rerun wtg/PIPE2D-1415-01 --id visit=106863 arm=b^r^n^m < reduceExposure.readLineList INFO: Filtered line lists ['CdI', 'HgI'] by {'Hg', 'Cd', 'Ar'}, keeping species {'CdI', 'HgI'}. < reduceExposure.centroidLines INFO: Measured 38080 line centroids > reduceExposure.readLineList INFO: Filtered line lists ['CdI', 'HgI', 'HgII'] by {'Ar', 'Cd', 'Hg'}, keeping species {'HgI', 'CdI', 'HgII'}. > reduceExposure.centroidLines INFO: Measured 5950 line centroids |
| Comment by Christian Kragh Jespersen [ 16/Jul/24 ] |
|
Should be, if I remember correctly there's another line close by, it's a blend with intermediate distance, so we can't really merge them nor separate them since we didn't have any info on the intensity of the other line. |
| Comment by Wilfred Gee [ 17/Jul/24 ] |
|
Checking on a single, visit (v106863, same as above), we see more lines detected but get some larger median and soften values, mostly for the wavelength in the the n and r arms. For n we simply weren't detecting any lines to have valid wavelengths (which is the issue that started us looking into this in the first place). Rebuilding the detectorMaps with these line lists should improve this so after merging this file I think the detectorMaps should be updated.
|
| Comment by Wilfred Gee [ 19/Jul/24 ] |
|
Merged after discussion with Kiyoto Yabe |
