[PIPE2D-1316] Move the location to import eups in fiberids.py of pfs_utils Created: 14/Oct/23  Updated: 03/Nov/23  Resolved: 17/Oct/23

Status: Done
Project: DRP 2-D Pipeline
Component/s: pfs_utils
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Normal
Reporter: monodera Assignee: Unassigned
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

fiberids.py in python/pfs/utils/ in pfs_uitls imports eups at the top section, but it is only used to look up the PFS_UTILS parameter using eups.productDir('PFS_UTILS'). As the constructor of FiberIds allows to be called with a path to the fiberid data directory, it would be nice if the import line is moved right above the line using eups to minimize the dependency to eups for Python environments not using it.

Specifically, I'd like to move the import line to here:

https://github.com/Subaru-PFS/pfs_utils/blob/b922f60fa44dec1a96dfb5739f2c2737486c04ec/python/pfs/utils/fiberids.py#L57

 Comments   
Comment by monodera [ 17/Oct/23 ]

done by merging the tickets/PIPE2D-1316 branch to the master branch.

Comment by monodera [ 03/Nov/23 ]

I've added a hotfix as tickets/PIPE2D-1316-hotfix to make makePfsDesign() compatible with providing the fiberIds data path.

 

Generated at Sat Feb 10 16:05:57 JST 2024 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.