[PIPE2D-1305] AdjustDetectorMapTask can raise RuntimeError Created: 27/Sep/23 Updated: 20/Jan/24 |
|
| Status: | Open |
| Project: | DRP 2-D Pipeline |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Story | Priority: | Normal |
| Reporter: | rhl | Assignee: | price |
| Resolution: | Unresolved | Votes: | 0 |
| Labels: | EDR | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Description |
|
The docs to AdjustDetectorMapTask state that the task raises {{ pfs.drp.stella.fitDistortedDetectorMap.FittingError}} and that's what reduceExposure catches. However, in reality the task raises {{RuntimeError(f"Insufficient good lines: {numGoodLines}vs {needNumLines}")}} which is not caught. I'd fix the try block, except that this behaviour is explicitly documented, so I'll leave it up to Paul to decide on the proper fix. |
| Comments |
| Comment by price [ 27/Sep/23 ] |
|
You're right about the different error types, but we should also ask why you have an exposure with insufficient lines. Can you provide full instructions to reproduce, please? |
| Comment by Kiyoto Yabe [ 20/Jan/24 ] |
|
Do we still have this problem? |