[PIPE2D-1300] Add option --doBoxcarExtraction to reduceExposure.py Created: 19/Sep/23 Updated: 31/Jan/24 |
|
| Status: | In Review |
| Project: | DRP 2-D Pipeline |
| Component/s: | pfs_pipe2d |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Story | Priority: | Normal |
| Reporter: | rhl | Assignee: | rhl |
| Resolution: | Unresolved | Votes: | 0 |
| Labels: | EDR | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Story Points: | 1 |
| Sprint: | EDR+AIT |
| Reviewers: | Kiyoto Yabe |
| Description |
|
There is low-level code to build boxcar fibre traces, but there's no way to use it from the command line. Please remedy this. |
| Comments |
| Comment by Kiyoto Yabe [ 07/Oct/23 ] |
|
I heard we already had this option, can we make this happen soonish? Also, should this ticket be assigned to rhl or price ? |
| Comment by rhl [ 07/Oct/23 ] |
|
rhl. I just have to push the work (after another check or two). |
| Comment by Kiyoto Yabe [ 07/Oct/23 ] |
|
Thank you. Good to know. |
| Comment by rhl [ 24/Oct/23 ] |
|
As requested! It seems to work |
| Comment by rhl [ 25/Oct/23 ] |
|
Taking this back. Updating the detector map reverts to the Profile-based extraction. Easy to fix, but not yet done |
| Comment by rhl [ 27/Oct/23 ] |
|
Fixed, I think. But note that you can't just extract all the spectra if the boxcar width much exceeds c. 6 pixels as the extraction code performs a simultaneous fit and the matrix is ill conditioned (and it wouldn't do what you wanted anyway). Use something like:
reduceExposure.py /work/drp --calib /work/drp/CALIB --rerun RERUN \
-c isr.doFlat=False isr.doFlatNir=True isr.doDark=False \
doBoxcarExtraction=True boxcarWidth=11 extractSpectra.fiberId="[9, 221, 243, 265, 506, 567, 596]" \
--id 98813 arm=b spectrograph=1
|
| Comment by rhl [ 27/Oct/23 ] |
|
Fixed, I think! But see note in ticket about specifying desired fibreIds |