[PIPE2D-1289] Refactor fitting of detectorMaps to specify what should be fit Created: 29/Aug/23 Updated: 30/Sep/23 Resolved: 30/Sep/23 |
|
| Status: | Done |
| Project: | DRP 2-D Pipeline |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Story | Priority: | Normal |
| Reporter: | price | Assignee: | price |
| Resolution: | Done | Votes: | 0 |
| Labels: | EngRun | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Sprint: | Eng13Oct |
| Description |
|
We need to be able to simply specify what elements of a detectorMap are to be fit. |
| Comments |
| Comment by price [ 21/Sep/23 ] |
|
detectorMap fitting occurs in two contexts: fitDetectorMap (called by reduceArc) and adjustDetectorMap (called by reduceExposure, etc). In order to satisfy the requirements introduced by this ticket, I propose to:
|
| Comment by price [ 22/Sep/23 ] |
|
We agreed at our weekly meeting that we would be able to provide values in addition to turning parameters on/off (i.e., don't default the value to zero if not being fit). rhl asked for a more detailed description of the detectorMap fitting process: The MultipleDistortionsDetectorMap consists of the following layers:
When running reduceArc (which calls fitDetectorMap), we have the measured distortions from the lines and traces relative to the base model. We iteratively:
When running reduceExposure (which calls adjustDetectorMap), we have the measured distortions from the lines and traces relative to the best detectorMap. We iteratively fit a distortion field (RotScaleDistortion for arm=n monolithic detector; DoubleDistortion for arm=b and arm=r two CCDs). |
| Comment by price [ 30/Sep/23 ] |
|
Also added MosaicPolynomialDistortion, which I think is more the sort of distortion model RHL was thinking (single distortion field, but with additional affine transform for the one of the CCDs) and fixed a few fitting things. Merged to master. |