[PIPE2D-1285] Allow generateCommands.py to control --doraise and --longlog Created: 16/Aug/23  Updated: 24/Aug/23  Resolved: 24/Aug/23

Status: Done
Project: DRP 2-D Pipeline
Component/s: pfs_pipe2d
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Normal
Reporter: cloomis Assignee: sogo.mineo
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Reviewers: price

 Description   

generateCommands.py should accept and pass though the task -doraise and longlog arguments. Currently, doraise is always added, and -longlog cannot be. Yes, we know that that Gen3 will require major changes, but those would help substantially in the meanwhile.

 Comments   
Comment by sogo.mineo [ 22/Aug/23 ]

Should I make both -doraise and --longlog optional, or always use them forcibly? Though I have added -doraise to the command lines, I don't exactly know the effect of this option.

Comment by sogo.mineo [ 23/Aug/23 ]

Another question: What is the argument of --longlog option?

Comment by price [ 23/Aug/23 ]

--doraise causes iteration over the dataId to immediately cease, and to raise the exception (allowing it to be trapped if you run under pdb with a single process). If you leave it off, the command will continue iterating and log at the end how many failed.
--longlog requires an argument, but that argument isn't respected at all (a bug). I think people often put --longlog 1, I often use --longlog FOO.

Comment by sogo.mineo [ 23/Aug/23 ]

Thanks. As for --longlog, I think it will be enough if I always add --longlog=1 to the command lines.
As for --doraise, I think all I have to do is to omit --doraise when generateCommands.py is called with --allowErrors option, which already exists. Is it correct?

Comment by price [ 23/Aug/23 ]

I think that's right.

Comment by sogo.mineo [ 23/Aug/23 ]

Could you review the PR? I have made --doraise controllable according to the request, but I have decided to always use --longlog option.

Comment by sogo.mineo [ 24/Aug/23 ]

Merged. Thanks for reviewing.

Generated at Sat Feb 10 16:05:29 JST 2024 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.