[PIPE2D-1280] Fix weekly breakage 2023-08-06 Created: 08/Aug/23  Updated: 10/Aug/23  Resolved: 10/Aug/23

Status: Done
Project: DRP 2-D Pipeline
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Story Priority: Normal
Reporter: price Assignee: price
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

The 2023-08-06 weekly failed. It seems to be looking for a flat while constructing a dark:

127798 WARN  2023-08-06T08:03:37.398-0400 pfs.dark: Unable to process DataId(initialdata={'field': 'DARK', 'arm': 'n', 'dateObs': '2020-01-01', 'site': 'F', 'category': 'B', 'visit': 12, 'spectrograph': 1, 'ccd': 2, 'filter': 'n', 'expTime': 1800.0, 'dataType': 'DARK', 'taiObs': '2020-01-01T00:12:00', 'pfsDesignId': 1, 'slitOffset': 0.0}, tag=set()): Unable to retrieve flat for DataId(initialdata={'field': 'DARK', 'arm': 'n', 'dateObs': '2020-01-01', 'site': 'F', 'category': 'B', 'visit': 12, 'spectrograph': 1, 'ccd': 2, 'filter': 'n', 'expTime': 1800.0, 'dataType': 'DARK', 'taiObs': '2020-01-01T00:12:00', 'pfsDesignId': 1, 'slitOffset': 0.0}, tag=set()): No locations for get: datasetType:flat dataId:DataId(initialdata={'field': 'DARK', 'arm': 'n', 'dateObs': '2020-01-01', 'site': 'F', 'category': 'B', 'visit': 12, 'spectrograph': 1, 'ccd': 2, 'filter': 'n', 'expTime': 1800.0, 'dataType': 'DARK', 'taiObs': '2020-01-01T00:12:00', 'pfsDesignId': 1, 'slitOffset': 0.0}, tag=set()).


 Comments   
Comment by price [ 08/Aug/23 ]

Fixed a logic bug in ISR introduced in PIPE2D-1071.
Turned off IPC correction for simulated data.

With those fixes, cosmic ray finding is taking forever. Discovered that the noise in the NIR images doesn't match expectations, and found a bug in how the readnoise is being done. With that fixed, I'm regenerating the simulated data for the weekly.

Comment by price [ 10/Aug/23 ]

Weekly passed using the new simulated data.

Merged all work to master.

Generated at Sat Feb 10 16:05:27 JST 2024 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.