[PIPE2D-128] Fix config directories Created: 23/Nov/16 Updated: 24/Nov/16 Resolved: 24/Nov/16 |
|
| Status: | Done |
| Project: | DRP 2-D Pipeline |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Bug | Priority: | Major |
| Reporter: | price | Assignee: | price |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Reviewers: | aritter |
| Description |
|
In |
| Comments |
| Comment by price [ 23/Nov/16 ] |
|
Sorry, aritter, I have another for you. This is a fix to problems I introduced in
price@price-laptop:~/PFS/obs_pfs (tickets/PIPE2D-128=) $ git sub
commit 5d52f2b37c45a02e98330335f28861fac27b7af0
Author: Paul Price <price@astro.princeton.edu>
Date: Tue Nov 22 18:03:49 2016 -0500
config: remove excess directory
The directory has been removed (PIPE2D-125) but this change wasn't
reflected in the config files.
config/bias.py | 2 +-
config/flat.py | 2 +-
config/processCcd.py | 3 +--
3 files changed, 3 insertions(+), 4 deletions(-)
commit d910c7e8ae31b75a5489974f99372bf2fde52312
Author: Paul Price <price@astro.princeton.edu>
Date: Tue Nov 22 18:04:46 2016 -0500
config: cleanup
Remove blank and commented lines, unnecessary imports.
config/arc.py | 14 --------------
config/bias.py | 1 -
config/flat.py | 1 -
config/isr.py | 4 ----
config/processCcd.py | 5 -----
5 files changed, 25 deletions(-)
|
| Comment by aritter [ 23/Nov/16 ] |
|
Why is e.g. `constructBias.py` still looking for config files in `config/pfs/`? `root INFO: Config override file does not exist: '/Users/azuri/stella-git/obs_pfs/config/pfs/bias.py'` Otherwise looks fine. |
| Comment by aritter [ 23/Nov/16 ] |
|
Also, there is still one file `constructFiberFlat.py` in `obs_pfs/config/pfs`. Missed that in the ticket |
| Comment by price [ 24/Nov/16 ] |
|
The CmdLineTask framework looks in both config and config/pfs (because it has no idea whether there's two cameras in that package or not), and warns if either doesn't exist. I added another commit to move constructFiberFlat.py down. |
| Comment by price [ 24/Nov/16 ] |
|
Merged to master. |