pipe2d-1264.png
tmp - 2023-07-20T220237.254.png
tmp - 2023-07-20T220256.397.png
[PIPE2D-1264] Shapes are not measured for bright lines Created: 21/Jul/23 Updated: 01/Aug/23 |
|
| Status: | Open |
| Project: | DRP 2-D Pipeline |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Story | Priority: | Normal |
| Reporter: | rhl | Assignee: | price |
| Resolution: | Unresolved | Votes: | 0 |
| Labels: | engRun12 | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Attachments: |
pipe2d-1264.png
tmp - 2023-07-20T220237.254.png
tmp - 2023-07-20T220256.397.png
|
| Description |
|
I took a look at the calculated moments from 96925 r1. I take it that xx is the xx adaptive moment (it'd be better if we called it something like Ixx). np.sum(np.isfinite(als.xx)), np.sum(np.isfinite(als.flux)), np.sum(np.isfinite(als.xx[als.flux > 25])) == (22204, 102735, 0) so none of the bright lines have measured moments. |
| Comments |
| Comment by rhl [ 25/Jul/23 ] |
|
This seemed to be related to a bad detectorMap. Our error reporting needs work (possibly waiting on gen3?) |
| Comment by price [ 01/Aug/23 ] |
|
What's going on here is that there are two types of measurements in the ArcLineSet: lines (arc or sky lines with a known wavelength) and traces (continuum). Traces can be identified as having description == "Trace"; everything else is a line. Only lines have measured second moments. Now, the lines and traces have different flux scales: the lines have been normalised by the reference quartz spectrum (because we need to be able to compare their fluxes across fibers), while the traces are not (we haven't had a need for their flux measurements). This is shown in the below figure, where I've separated the lines (blue) and traces (red): the left panel shows the different flux scaling, while the right panel shows that traces don't have any (finite) second moments. Is this something that needs fixing? If so, how do you want to fix it?
|
