[PIPE2D-1262] constructFiberProfiles.py can fail with a syntax error Created: 20/Jul/23 Updated: 01/Aug/23 Resolved: 01/Aug/23 |
|
| Status: | Done |
| Project: | DRP 2-D Pipeline |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Story | Priority: | Normal |
| Reporter: | rhl | Assignee: | price |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Description |
|
The command constructFiberProfiles.py /work/drp --calib /work/drp/CALIB --id arm=n spectrograph=3 visit=96895^96897^96900 --rerun rhl/eng-2023-07 --batch-type none -c isr.doFlat=False isr.doFlatNir=False isr.doIPC=True psfFwhm=3 forceFiberIds=True profiles.doBlindFind=False profiles.profileRadius=3 rerunISR=False --clobber-config -j 10 fails with File "/home/rhl/PFS/drp/stella/python/pfs/drp/stella/constructFiberProfilesTask.py", line 212, in combine date = profiles.getVisitInfo().getDate() AttributeError: 'lsst.daf.base.propertyContainer.propertyList.Prope' object has no attribute 'getDate' It's true; profiles.getVisitInfo() is not a VisitInfo. Fortunately the command with the options isr.doFlat=False isr.doFlatNir=False isr.doIPC=True profiles.profileRadius=2 profiles.profileSwath=2000 profiles.profileOversample=5 runs to completion |
| Comments |
| Comment by price [ 01/Aug/23 ] |
|
Setting forceFiberIds=True uncovered some bitrot in the use of FiberProfileSet.makeEmpty. (You probably don't need forceFiberIds=True since you're doing doBlindFind=False; and doBlindFind=False is the default anyway.) |
| Comment by price [ 01/Aug/23 ] |
|
Fix merged to master. |