[PIPE2D-125] Fixups from onboarding Created: 17/Nov/16  Updated: 23/Nov/16  Resolved: 23/Nov/16

Status: Done
Project: DRP 2-D Pipeline
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Major
Reporter: price Assignee: price
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Reviewers: aritter

 Description   

I've noticed various little things to be fixed as I've explored the codebase and run the tutorial. This ticket is a grab-bag for those.



 Comments   
Comment by price [ 17/Nov/16 ]
price@price-laptop:~/PFS/drp_stella (tickets/PIPE2D-125=) $ git sub
commit 3c3402df8072525354772a578f824932c028d303
Author: Paul Price <price@astro.princeton.edu>
Date:   Thu Nov 17 09:28:29 2016 -0500

    remove unnecessary files

 myConfig.py                              | 11 -----------
 python/bin/exampleCmdLineTask.py         | 25 -------------------------
 python/pfs/drp/stella/calcTwoDPSF        |  1 -
 python/pfs/drp/stella/setup              |  4 ----
 python/pfs/drp/stella/valgrind_calc2dpsf |  1 -
 5 files changed, 42 deletions(-)


price@price-laptop:~/PFS/obs_pfs (tickets/PIPE2D-125=) $ git sub
commit edeafa2d80fbf5edec8b0d537c6172f321669673
Author: Paul Price <price@astro.princeton.edu>
Date:   Wed Nov 16 17:03:53 2016 -0500

    genDefectFits: reduce chatter
    
    Excess chatter was obscuring the build process.

 bin.src/genDefectFits.py | 10 ----------
 1 file changed, 10 deletions(-)

commit a005830364310c69c0b237d956f60d0067ccc599
Author: Paul Price <price@astro.princeton.edu>
Date:   Wed Nov 16 17:05:11 2016 -0500

    genDefectFits: remove illusion of choice
    
    A choice from a menu with a single item is not a choice.
    There's no need to select a mapper because we know what
    you're going to choose.

 bin.src/genDefectFits.py | 9 +++------
 pfs/SConscript           | 2 +-
 2 files changed, 4 insertions(+), 7 deletions(-)

commit 17ecfefe252a3dac30babb9534d583ed29005e4d
Author: Paul Price <price@astro.princeton.edu>
Date:   Wed Nov 16 17:19:17 2016 -0500

    genDefectFits: fix deprecation of pyfits.new_table
    
    Gets rid of the deprecation warning.

 bin.src/genDefectFits.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

commit a6930c8b9e4c535d2b46bee0208e8d4bf8680984
Author: Paul Price <price@astro.princeton.edu>
Date:   Wed Nov 16 20:15:44 2016 -0500

    genCalibRegistry: modernise
    
    Put functionality into a function.
    Remove postgres support (unused).
    ArugmentParser instead of OptionParser.
    Remove camera argument (only works for PFS).

 bin.src/genCalibRegistry.py | 200 +++++++++++++++++---------------------------
 1 file changed, 75 insertions(+), 125 deletions(-)

commit 243f2eb3b6daea34951ce16922f2a8e15f245041
Author: Paul Price <price@astro.princeton.edu>
Date:   Wed Nov 16 20:44:28 2016 -0500

    config: remove extraneous directory
    
    There's only one camera in this obs package, so no need to put
    everything under a camera-specific directory.

 config/arc.py               | 14 ++++++++++++++
 config/bias.py              | 12 ++++++++++++
 config/createRefSpec.py     |  2 ++
 config/dark.py              | 10 ++++++++++
 config/detrend.py           | 11 +++++++++++
 config/flat.py              | 11 +++++++++++
 config/ingest.py            | 42 ++++++++++++++++++++++++++++++++++++++++++
 config/isr.py               | 18 ++++++++++++++++++
 config/pfs/arc.py           | 14 --------------
 config/pfs/bias.py          | 12 ------------
 config/pfs/createRefSpec.py |  2 --
 config/pfs/dark.py          | 10 ----------
 config/pfs/detrend.py       | 11 -----------
 config/pfs/flat.py          | 11 -----------
 config/pfs/ingest.py        | 42 ------------------------------------------
 config/pfs/isr.py           | 18 ------------------
 config/pfs/processCcd.py    | 14 --------------
 config/processCcd.py        | 14 ++++++++++++++
 18 files changed, 134 insertions(+), 134 deletions(-)

commit 8debd51de66be2484d29594d7ee98519c10809e3
Author: Paul Price <price@astro.princeton.edu>
Date:   Wed Nov 16 20:47:20 2016 -0500

    constructFiberTrace: set default config values

 python/lsst/obs/pfs/constructFiberTraceTask.py | 7 +++++++
 1 file changed, 7 insertions(+)
Comment by price [ 17/Nov/16 ]

swinbank, would you please review or assign this for review?

Comment by swinbank [ 18/Nov/16 ]

aritter, would you mind reviewing this, please?

Comment by aritter [ 22/Nov/16 ]

Only one comment for commit a6930c8. Good to merge once commend has been addressed.

Comment by price [ 23/Nov/16 ]

Thanks!

Merged to master.

Generated at Sat Feb 10 15:48:42 JST 2024 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.